Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Equality check does not work on Windows #111
Part of /bitshares/bitshares-core/issues/1593
Compiling on Windows causes an error. It seems the compiler cannot determine which equality operator to use given the arguments. As a "fix", the preprocessor removes this test line from Windows builds.
"E:\bitshares-core-hardfork\install.vcxproj" (default target) (1) ->
I do not like this fix, as it is not testing a feature that could be used elsewhere (which I assume would also fail to compile). It looks as if the way equality is done here is broken (on Windows), and needs to be fixed. Input from others would be appreciated.
Hm, I'd have thought that
I think what happens here is that
Have you tried changing the
Error in VisualStudio:
So it seems to me it cannot decide between turning
Adding the <Types...> to the operator == didn't seem to help. Changing
That just compares two integers. I agree this is not what we want to test here because we already test it in the line above that.