Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref bitshares-core#1584 Fix some warnings #116

Merged
merged 4 commits into from Mar 26, 2019

Conversation

2 participants
@nathanhourt
Copy link

commented Mar 24, 2019

No description provided.

FC_LOG_MESSAGE( LOG_LEVEL, "${what}: " FORMAT,__VA_ARGS__("what",e.what())), \
fc::std_exception_code,\
typeid(e).name(), \
e.what() ) ; throw fce;\
e.what() ) ;\

This comment has been minimized.

Copy link
@nathanhourt

nathanhourt Mar 24, 2019

Author

I get a warning on these called "throw by value, catch by reference" -- the compiler recommended throwing an anonymous value if you plan to catch by reference, since a named, stack-allocated value technically can't be caught by reference (the stack it was allocated on has been destroyed).

Compiler handles it correctly either way, but this way is more complicit with formal C++ memory rules.

Fix warning
Not sure what the story is with this file, but it's making a
warning and this fixes it.

@nathanhourt nathanhourt referenced this pull request Mar 25, 2019

Merged

Fix some warnings #1677

nathanhourt added some commits Mar 25, 2019

More tweaks vis-a-vis warnings
Move crc_c fake usage out of strange main() function in a library
Convert manual string formatting to FC string formatting

@nathanhourt nathanhourt merged commit cab0a4e into bitshares:master Mar 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathanhourt nathanhourt deleted the nathanhourt:warnings branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.