Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1898: Fix crash in API #145

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@nathanhourt
Copy link

commented Aug 11, 2019

This resolves issue bitshares/bitshares-core#1898

We were getting the moral equivalent of a null pointer dereference by
incrementing an iterator past its past-the-end position, then
dereferencing it. This is now fixed.

Resolve #1898: Fix crash in API
We were getting the moral equivalent of a null pointer dereference by
incrementing an iterator past its past-the-end position, then
dereferencing it. This is now fixed.
@abitmore

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Update the test case please?

@nathanhourt

This comment has been minimized.

Copy link
Author

commented Aug 12, 2019

I was unable to reproduce the crash in unit testing.

@abitmore abitmore changed the base branch from master to optional-api-fix Aug 13, 2019

@abitmore abitmore merged commit 17c4639 into bitshares:optional-api-fix Aug 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathanhourt nathanhourt deleted the nathanhourt:bts_1898 branch Aug 13, 2019

@abitmore abitmore added this to the core release 3.3.0 milestone Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.