Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional API arguments #146

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@abitmore
Copy link
Member

commented Aug 13, 2019

For bitshares/bitshares-core#1898.

Added test case, merged @nathanhourt's patch.

nathanhourt and others added 3 commits Aug 11, 2019
Resolve #1898: Fix crash in API
We were getting the moral equivalent of a null pointer dereference by
incrementing an iterator past its past-the-end position, then
dereferencing it. This is now fixed.
@nathanhourt
Copy link

left a comment

Thanks, abit :)

@abitmore abitmore merged commit f7a1e53 into master Aug 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abitmore abitmore deleted the optional-api-fix branch Aug 13, 2019

@oxarbitrage oxarbitrage referenced this pull request Aug 15, 2019
1 of 17 tasks complete

@abitmore abitmore added this to the core release 3.3.0 milestone Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.