Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to run sonar-scanner during travis build #49

Merged
merged 3 commits into from Jun 5, 2018

Conversation

2 participants
@pmconrad
Copy link

commented May 13, 2018

This PR is mostly identical to #46, the only difference being that it is an internal PR (i. e. from a branch inside this repo, while the other is from by private repo).
Sonar-scanner should be executed for the PR (it was already executed when I pushed the branch to this repo, but should be run separately for the PR).

@pmconrad

This comment has been minimized.

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jun 4, 2018

when i click the link i get redirected to a login screen. when i select github it goes briefly to the repo inside sonar but immediately back to the login page. seems an auth issue. @pmconrad you maybe need to add others to have access? if so, please add me.

@pmconrad

This comment has been minimized.

Copy link
Author

commented Jun 4, 2018

@oxarbitrage oxarbitrage self-requested a review Jun 4, 2018

@oxarbitrage
Copy link
Member

left a comment

thanks. looks good. lets keep testing it merged into master.

@pmconrad pmconrad merged commit 0dbf7ff into master Jun 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.