Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust asserts in fc/crypto #54

Merged
merged 1 commit into from Jun 7, 2018

Conversation

2 participants
@jmjatlanta
Copy link

commented Jun 2, 2018

Issue bitshares/bitshares-core#992

Adjusted some asserts in the fc/crypto area. Some should have been static_assert or FC_ASSERT.

The impact of the change from assert to static_assert is minor (we can catch them at compile time, so why not?).

The 1 switch from assert to FC_ASSERT in elliptic_common.cpp is a bit more impactful. Please consider the side effects as you do your review.

Hat tip to the EOS folks. More information: EOSIO/eos#3560

@pmconrad

This comment has been minimized.

Copy link

commented Jun 5, 2018

secexp = (seed + z) % order implies that secexp < order. order is well-known and constant, at least until we switch to another curve (which is extremely unlikely). The assertion cannot be triggered.

@jmjatlanta jmjatlanta merged commit d8437ac into master Jun 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmjatlanta jmjatlanta deleted the jmj_issue_992 branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.