Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc::time_point_sec::to_iso_string is broken #597 #67

Merged
merged 2 commits into from Jul 27, 2018

Conversation

4 participants
@cogutvalera
Copy link
Member

commented Jul 27, 2018

@jmjatlanta
Copy link

left a comment

Minor change requested. See below.

@@ -38,8 +38,11 @@ BOOST_AUTO_TEST_CASE(time_point_sec_test)

time_point_sec tp3g(0xc0000000U);
// commented next 2 tests as they will only work with boost >= 1.64
//BOOST_CHECK_EQUAL( "2072-01-28T16:51:12", tp3g.to_iso_string() );

This comment has been minimized.

Copy link
@jmjatlanta

jmjatlanta Jul 27, 2018

Please remove (now inaccurate) comment above.

Successfully tested with Boost 1.65.

This comment has been minimized.

Copy link
@cogutvalera

cogutvalera Jul 27, 2018

Author Member

Thanks !

@@ -37,9 +37,10 @@ BOOST_AUTO_TEST_CASE(time_point_sec_test)
BOOST_CHECK_EQUAL( "20380119T031408", tp2g.to_non_delimited_iso_string() );

time_point_sec tp3g(0xc0000000U);
// commented next 2 tests as they will only work with boost >= 1.64
//BOOST_CHECK_EQUAL( "2072-01-28T16:51:12", tp3g.to_iso_string() );
//BOOST_CHECK_EQUAL( "20720128T165112", tp3g.to_non_delimited_iso_string() );

This comment has been minimized.

Copy link
@oxarbitrage

oxarbitrage Jul 27, 2018

Member

please remove this 3 commented lines. thanks.

This comment has been minimized.

Copy link
@jmjatlanta

jmjatlanta Jul 27, 2018

Already done. See raw file.

This comment has been minimized.

Copy link
@oxarbitrage

oxarbitrage Jul 27, 2018

Member

ops, seems you are right, sorry.

This comment has been minimized.

Copy link
@cogutvalera

cogutvalera Jul 27, 2018

Author Member

there aren't comments, removed already, look last commit please

@oxarbitrage
Copy link
Member

left a comment

looks good to me too.

@@ -37,9 +37,10 @@ BOOST_AUTO_TEST_CASE(time_point_sec_test)
BOOST_CHECK_EQUAL( "20380119T031408", tp2g.to_non_delimited_iso_string() );

time_point_sec tp3g(0xc0000000U);
// commented next 2 tests as they will only work with boost >= 1.64
//BOOST_CHECK_EQUAL( "2072-01-28T16:51:12", tp3g.to_iso_string() );
//BOOST_CHECK_EQUAL( "20720128T165112", tp3g.to_non_delimited_iso_string() );

This comment has been minimized.

Copy link
@oxarbitrage

oxarbitrage Jul 27, 2018

Member

ops, seems you are right, sorry.

@jmjatlanta jmjatlanta merged commit e310159 into bitshares:master Jul 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cogutvalera

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2018

Thanks guys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.