New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize max_object_depth in appender config #83

Merged
merged 2 commits into from Oct 19, 2018

Conversation

3 participants
@abitmore
Member

abitmore commented Oct 19, 2018

by setting a default value, for file_appender and gelf_appender.
For issue bitshares/bitshares-core#1392

abitmore added some commits Oct 19, 2018

Initialize max_object_depth in appender config
by setting a default value, for file_appender and gelf_appender.
For issue bitshares/bitshares-core#1392

@abitmore abitmore referenced this pull request Oct 19, 2018

Closed

Error while converting value to string #1392

1 of 17 tasks complete
@jmjatlanta

This comment has been minimized.

jmjatlanta commented Oct 19, 2018

Q: Do we need to do the same in console_appender.hpp?

Update: Nevermind. The constructor takes care of it.

@abitmore

This comment has been minimized.

Member

abitmore commented Oct 19, 2018

I didn't add that to console appender because it has a default constructor which does the same.

@pmconrad

Looks good, thanks!

@abitmore abitmore merged commit a1d84f2 into master Oct 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abitmore abitmore deleted the log-obj-depth branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment