Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] How to clear voting proxy? #1525

Closed
abitmore opened this issue May 18, 2018 · 4 comments
Closed

[1.5] How to clear voting proxy? #1525

abitmore opened this issue May 18, 2018 · 4 comments
Assignees
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks
Milestone

Comments

@abitmore
Copy link
Member

Describe the bug
There was a "clear proxy" button in order versions e.g. 2.0.160420. But now we only have 2 buttons: "save" and "reset". It seems the "proxy" text box doesn't accept empty name. Clicking "reset" doesn't clear it as well.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wallet.bitshares.org/#/account/chainsquad/voting
  2. Click on the drop-down box with no label
  3. input something, select an account name
  4. Click reset
  5. Click on the drop-down box
  6. input nothing
  7. click the white lock icon (or anywhere outside the box)

Expected behavior

  • Able to clear proxy.
  • The drop-down box should have a label.

Screenshots
image
image
image
image

Desktop (please complete the following information):

  • OS: Win7
  • Browser: Chrome
  • Version: latest
@startailcoon
Copy link
Contributor

Idd, we are missing a 'clear vote' button.

@startailcoon
Copy link
Contributor

This issue requires some tinkering with Typeahead and handling empty values or resets. I've been unable to find a good way to handle this.

@wmbutler
Copy link
Contributor

I'm not convinced we need a typeahead for the proxy input field. Maybe we can keep this easy by eliminating the typeahead. what if we:

  • remove the lock
  • replace the lock with a "Clear Proxy" button
  • When proxy is set, make input field locked / disabled with Clear Proxy button displayed

@wmbutler wmbutler added the [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks label May 20, 2018
@wmbutler wmbutler added this to the 180525 milestone May 20, 2018
@wmbutler wmbutler changed the title How to clear voting proxy? [1.5] How to clear voting proxy? May 20, 2018
@startailcoon
Copy link
Contributor

I can take this and change it to a non-typeahead style so we can handle empty inputs.

@startailcoon startailcoon self-assigned this May 28, 2018
@wmbutler wmbutler modified the milestones: 180525, 180605 May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks
Projects
None yet
Development

No branches or pull requests

3 participants