Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2][happyconcepts] Expiration Time display in Open Orders #1529

Closed
happyconcepts opened this issue May 19, 2018 · 15 comments
Closed

[2][happyconcepts] Expiration Time display in Open Orders #1529

happyconcepts opened this issue May 19, 2018 · 15 comments
Labels
Milestone

Comments

@happyconcepts
Copy link
Contributor

@happyconcepts happyconcepts commented May 19, 2018

Order expiration time(s) shown via tooltip in Open Orders display on the Exchange page are not displayed in user's local time. Please refer to #1397 for expected behavior and screenshot.

Unlike the modal, multiple orders can be displayed on this page. I don't see it taking more than 1 hour, mostly testing. Since this was out of scope for that issue, I have started this new one.

I would like to claim this and can deliver for the next sprint. Greetings from Los Angeles.

@wmbutler wmbutler changed the title Expiration Time display in Open Orders [2][happyconcepts] Expiration Time display in Open Orders May 20, 2018
@startailcoon

This comment has been minimized.

Copy link
Contributor

@startailcoon startailcoon commented Jun 17, 2018

@happyconcepts how is your work progressing? You mentioned that this would be delivered to "next sprint" last month. Do you still plan on completing this task or release it?

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 18, 2018

@startailcoon The wrong information you gave me on #1570 has only delayed me momentarily on this issue.

@startailcoon

This comment has been minimized.

Copy link
Contributor

@startailcoon startailcoon commented Jun 18, 2018

Just checking in on uncompleted issues. Sorry for the unintentional confusion on your other issue.

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 18, 2018

I believe you could help with debugging on #1570 and finish what you started with the node selection mess, but it's not my job to set your priorities.

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 18, 2018

I guess I will do this today for the new develop branch @wmbutler thanks for your support.

@svk31

This comment has been minimized.

Copy link
Contributor

@svk31 svk31 commented Jun 18, 2018

@happyconcepts what's with the attitude? I looked at the issue and he didn't give you any wrong information.

@startailcoon

This comment has been minimized.

Copy link
Contributor

@startailcoon startailcoon commented Jun 19, 2018

@happyconcepts I don't see the reason for your tone here. Please keep your comments constructive.

I don't understand what you mean about "finish what you started with the node selection mess". I've only made a comment in the discussion. The node handling have been worked on for several different issues before and can still need more attention as mentioned there.

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 19, 2018

@happyconcepts what's with the attitude? I looked at the issue and he didn't give you any wrong information.

Hidden nodes do not autoconnect? My client connected to a compromised Open Ledger domain despite being hidden. But that's another issue #1570 not this one.

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 19, 2018

@startailcoon:

I don't see the reason for your tone here. Please keep your comments constructive.

You know, I was about to say the say exact thing to you. Because here we are, in the only two issues I have right now on this project, and you @startailcoon have not provided a single constructive comment.

My neck happens to be broken from a car accident, but that's not going to change the disgustingly dismissive tone you have used toward me and any of my comments, contributions, etc since I started in July almost a full year ago.

@startailcoon

This comment has been minimized.

Copy link
Contributor

@startailcoon startailcoon commented Jun 19, 2018

happyconcepts you having an accident is unfortunate, but I don't see the relevance of bringing it up here. If you have found my comments disgruntled, it was not my intention.

As soon as I have some time over, probably tomorrow, I can help you out with debugging your other issue, which are indeed relevant as you've mentioned. I have never tried to say otherwise.

Let's move forward and find solutions to our issues instead.

@gibbsfromncis

This comment has been minimized.

Copy link
Contributor

@gibbsfromncis gibbsfromncis commented Jun 19, 2018

@happyconcepts stop to be like a dick. Anyway, your personal things or accidents or anything else don't give you any reason to rude or blame other guys who tries to help you and bitshares at all. Be polite anytime. If you can't deliver your work just unassign yourself or wait while somebody other will unassign you.

@gibbsfromncis

This comment has been minimized.

Copy link
Contributor

@gibbsfromncis gibbsfromncis commented Jun 19, 2018

@happyconcepts Anyway, nobody shouldn't help you. Guys expect from you just 2 things - request to claim and pull-request with the done issue. We spend our time to help you earn money and deliver your work. If you continue to be like an asshole you won't get any help or responses (especially from my side, I cannot answer from other guys)

@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 20, 2018

You have never helped me @gibbsfromncis, so it's quite shallow and egotistical for you to suggest that you will "stop" helping me.

Hidden nodes do not autoconnect? My client connected to a compromised Open Ledger domain despite being hidden.

This remains the technical issue, but instead of help you continue to choose to attack me with ad hominem...

This is the communication issue, and what I replied to @startailcoon:

You know, I was about to say the say exact thing to you. Because here we are, in the only two issues I have right now on this project, and you @startailcoon have not provided a single constructive comment.

And look at this, none of you address the issue. Now you salivate about using my broken neck to make your case that I am the dick.

Can I get back to working on this issue now, or will you continue to turn this repo into a bullshit chatroom?

@svk31

This comment has been minimized.

Copy link
Contributor

@svk31 svk31 commented Jun 20, 2018

@happyconcepts please just stick to the issue, the simple question that triggered your ranting still remains unanswered: do you intend to complete the issue or can someone else take it over?

@wmbutler wmbutler modified the milestones: 180615, 180701 Jun 20, 2018
@happyconcepts

This comment has been minimized.

Copy link
Contributor Author

@happyconcepts happyconcepts commented Jun 21, 2018

it's basically done @svk31. I just have to figure out how to migrate my process to the develop branch, and with a broken neck it's hard enough. All the fuzzing and heckling just delays it. Anyone else's issues languish for months but mine is selectively enforced because ... there is so much love here for me?

So this PR should arrive by Saturday June 23 to develop and I hope that is acceptable with enough time in staging prior to the newly slated July 1 sprint.

Thank you sigve for your sensibility.

happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Jun 23, 2018
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Jun 23, 2018
happyconcepts added a commit to happyconcepts/bitshares-ui that referenced this issue Jun 23, 2018
@svk31 svk31 changed the title [2][happyconcepts] Expiration Time display in Open Orders [0.5][happyconcepts] Expiration Time display in Open Orders Jun 24, 2018
@svk31 svk31 closed this in 1d7ddf4 Jun 24, 2018
svk31 added a commit that referenced this issue Jun 29, 2018
@wmbutler wmbutler changed the title [0.5][happyconcepts] Expiration Time display in Open Orders [2][happyconcepts] Expiration Time display in Open Orders Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.