Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10][dot5enko] Margin Position Updates #2127

Closed
startailcoon opened this Issue Nov 6, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@startailcoon
Copy link
Contributor

commented Nov 6, 2018

The UI Margin Position code is overdue for a refactoring to simplify the underlying code.

  • Refactor app/components/Account/MarginPositions.jsx

Related tasks are

  • #2007 - No update on available DEBT asset
  • #2004 - Redesign & Antify Borrow Modal
  • #2005 - No working COLLATERAL lock
@dot5enko

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

can i claim it?
is it include related tasks or they just simply related ? :)

@startailcoon

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2018

@dot5enko I'm assigning all three issues to you. I feel 2007 and 2004 touches the same concept, so I have only added hours to one of them. If you feel you need any clarification of these two issues, please post them in respective issue thread. 👍

@startailcoon startailcoon changed the title [5] Margin Position Updates [5][dot5enko] Margin Position Updates Nov 8, 2018

@startailcoon

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

I've added #2005 - No working COLLATERAL lock to the list of related tasks. This adresses an issue, that may or may not be solved as part of the other two.

@dot5enko

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2018

ok

@froooze

This comment has been minimized.

Copy link

commented Nov 12, 2018

@dot5enko: I wrote a lot on the margin picker topics, can you integrate my ideas? What do you think ?

@dot5enko

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

@froooze of course i'll look at them

dot5enko added a commit to dot5enko/bitshares-ui that referenced this issue Nov 14, 2018

@dot5enko

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

@startailcoon i've refactored the code and fixed #1098 alongside. Frankly speaking the code was terrible and i exceeded estimate a bit:) including #1098 it took around 11h. if its possible can you add the rest?
Also, related tasks were not accepted for integration by @wmbutler yet ( see #2004 )

@startailcoon

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

Nice work @dot5enko
Wasn't unexpected that this would take a bit longer than estimated. I'll push this to 10 hours + the 1 hour on #1098.

@startailcoon startailcoon changed the title [5][dot5enko] Margin Position Updates [10][dot5enko] Margin Position Updates Nov 14, 2018

@wmbutler wmbutler modified the milestones: 181114, 181128 Nov 18, 2018

sschiessl-bcp added a commit that referenced this issue Nov 26, 2018

@Kennybll Kennybll referenced this issue Dec 14, 2018

Closed

[2.0.181212-rc1] Integration testing by Kennybll #2334

2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.