#1794 - Notify if settle is worth less than market value

[kapeer42]

Closes #1794

This might require some discussion and commits.

The way I get the market price is by calling the api's get_order_book directly but this means a few things:

• I get real numbers comparison, so if the price difference is less than the precision, it's undefined behavior
• If the order book changes after the modal is opened, it is ignored.
• Any optimization done in the MarketsStore is bypassed

I think turning the ExchangeSubscriber component into an HOC might be a proper way to do it but it seems outside the scope of the initial issue.

Maybe someone can point me to a better way to do it?

Demo:

[kapeer42]

CI going crazy xD

[abitmore]

I think it's better to call get_ticker rather than get_order_book, although get_ticker doesn't return volume, usually it's fine. Update: it's fine (and even better, performance-wise) since you called get_order_book with a small limit parameter.

If the client has subscribed to market already, I guess the order book / ticker data should have been cached so perhaps can use the cache directly.

[sschiessl-bcp]

kapeer42 are you available on Telegram or any other live-chat app?

[kapeer42]

@sschiessl-bcp discord

[sschiessl-bcp]

Please include the full qualified market name ( XXX / BTS ) as the link

[kapeer42]