Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoinMarketCap issues #12

Open
abitmore opened this issue Jul 21, 2019 · 13 comments

Comments

@sschiessl-bcp sschiessl-bcp changed the title coinmarketcap issues CoinMarketCap issues Jul 23, 2019

@dls-cipher

This comment has been minimized.

Copy link

commented Jul 23, 2019

Assign me for now please. I'm reaching out to 3 contacts:

  • Carylyne Chan (CMC CSO) via LinkedIn
  • GlissBTC (CMC) via email - thanks to Ronny from @OpenLedgerApp
  • Default CMC contact via GoogleDocs form on their website

To try to apply extension over 14 June + 45 days given general grace period for new requirements of CMC, in order to better organize and provide them all of them.

Also, BitShares Asset Exchange and BitShares asset profiles on CMC will be updated for more accurate/correct data/links/content.

I'll keep updates on this Issue here and in BitSharesTalk discussion

@sschiessl-bcp

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

CryptoBridge had similar issues, please reach out to them.

@sschiessl-bcp

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

Answer to bitcoinsfacil - pedro

Hi Pedro,

Please note that we have initiated the first steps of the Data Accountability & Transparency Alliance. You can learn more about the alliance here https://coinmarketcap.com/data-transparency-alliance/ and see the details in our blog post https://blog.coinmarketcap.com/2019/05/01/happy-6th-birthday-data-alliance-block-explorers-and-more/ found under the heading 'Phase 1 (Exchanges) Trade and order book data'.

The exclusion of volumes from BitShares Asset Exchange is not by accident. It is however related to API documentation not meeting our latest requirements for Phase 1 of the DATA initiative. Please review these links for more info.

To help us ensure we can feature markets from this exchange with volumes included. Can you also provide documentation for the following endpoints as well?

    Live trading data: Ongoing live trade data provided via API (example)
    Live order book data: Ongoing order book data provided via API (example)
@bitcoinsfacil

This comment has been minimized.

Copy link

commented Jul 24, 2019

1.- Live trading data: Ongoing live trade data provided via API example
2.- Live order book data: Ongoing order book data provided via API example

@dls-cipher

This comment has been minimized.

Copy link

commented Jul 27, 2019

1.- Live trading data: Ongoing live trade data provided via API example
2.- Live order book data: Ongoing order book data provided via API example

Can you provide details on your temporary solution of wrapping that data (from our convo in TG) and what would be estimate on job done ?

@ryanRfox and @xeroc would be following up on hours/bounty from core and code audit - in my humble opinion.

Chee®s

@CryptickCryptick1

This comment has been minimized.

Copy link

commented Jul 27, 2019

So I am glad to see coin market cap finally getting serious about ending wash trading. Various studies indicate that 92% of trading is wash trading. BitShares is one of the few blockchain based exchanges were all data is as open on the BTS blockchain. There are multiple explorers that could make it very easy to spot audit our trading.
http://bts.ai/market/BTS_CNY
https://bitsharescan.com/buy-sell/OPEN.ETH_BTS
https://www.cryptofresh.com/assets

I know that some wash trading happens on our exchanges, but generally it is much less than other exchanges from what I have seen. I would hope that providing them some of the explorers may provide the data they need for an audit. I suspect most of the exchanges that are a "problem" are sinning much worse than BitShares. I would hope that CMC realizes that we do have a variety of bots on the exchanges, and they compete with different strategies. Some do triangle arb, some do simple market making, some are engaged in other trading strategies. These are things one need to consider. I suspect this is going to an ongoing issue for CMC going forward, and it does need to be addressed. It might seem like it will hurt BTS in the short term, but once the wash trading is removed, BTS's real volume will make our reputation rise significantly.

@bitcoinsfacil

This comment has been minimized.

Copy link

commented Jul 27, 2019

@oxarbitrage suggested integrating the APIs that are needed in here https://github.com/bitshares/bitshares-explorer-api

I think we should have a temporary solution and attack this nonsense with a patch that is practical and erases any possibility of us getting out of CMC. Not complying with their new rules will definitely be a problem that we should solve.

Whether we like it or not, media and normal users check CMC to understand how a blockchain is doing. It is a strong marketing point if we could also add the real values on bitUSD and make it a contender on the stable coin fight.

Cheers

@dls-cipher

This comment has been minimized.

Copy link

commented Jul 28, 2019

@oxarbitrage suggested integrating the APIs that are needed in here https://github.com/bitshares/bitshares-explorer-api

I think we should have a temporary solution and attack this nonsense with a patch that is practical and erases any possibility of us getting out of CMC. Not complying with their new rules will definitely be a problem that we should solve.

Whether we like it or not, media and normal users check CMC to understand how a blockchain is doing. It is a strong marketing point if we could also add the real values on bitUSD and make it a contender on the stable coin fight.

Cheers

I like you as addition to "Reasonable" group of people. We are in regulated business industry and we rely/depend on a lot of factors from it, especially CoinMarketCap, where not just people but all major exchanges are looking at.

@oxarbitrage and @bitcoinsfacil please discuss with @ryanRfox your efforts for this and super important for me: ETA in days.

I'll follow up with Phase 2/3 legal docs and responses to the questions on details for our exchange. Google doc for public discussion will be available later today.

Chee®s

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

I have no issues of adding the API calls they need into bitshares-excplorer(https://explorer.bitshares-kibana.info/apidocs/) for coinmarket cap and others to use as part of my normal job in the core team. Do what they need, charge the hours it takes me to do it to the core.

In the other hand the exact API calls they need are for me yet not clear to make an estimate or go further.

@sschiessl-bcp

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

CryptoBridge already has it implemented and it is as simple as it comes. For Phase 2 I have agreed now that they will let us know when they start efforts on their end and we will make it a joint effort.

Here is the implementation of CB for CMC
https://api.crypto-bridge.org/docs/v2/#/market
It is almost an exact copy of the BitFinex integration and written in NodeJS, and we could have the code if desired. It is almost just a 1:1 mapping of what we already have available on a Node anyways, and I would prefer a python implementation.

Suggestion
We setup bitshares.org/api/v1/market in accordance with the above API. Then we can redirect it to whatever we seem suitable, for example we can include the necessary calls in the wrapper of the infrastructure worker. This is the old version of https://explorer.bitshares-kibana.info/apidocs/ , which contains almost the desired queries, just reformatted.

Also nice-to-read
https://hackernoon.com/the-ideal-crypto-trading-api-b1bbb2675875

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Please let me know if you want me to do something, i will prefer to not be part of a discussion of what it will be the best but just implement a fix if you guys are in a hurry.

@sschiessl-bcp

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

Please let me know if you want me to do something, i will prefer to not be part of a discussion of what it will be the best but just implement a fix if you guys are in a hurry.

Yes, no problem. I will ping you when we are at that stage!

@bitcoinsfacil

This comment has been minimized.

Copy link

commented Jul 29, 2019

@sschiessl-bcp excellent I had pinged Cryptobridge also and they sent me to the same endpoint. Aligned thinking good to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.