Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Memo.decrypt() type annotation #164

Closed
Algruun opened this issue Dec 7, 2018 · 0 comments
Closed

Invalid Memo.decrypt() type annotation #164

Algruun opened this issue Dec 7, 2018 · 0 comments

Comments

@Algruun
Copy link
Contributor

Algruun commented Dec 7, 2018

Method decrypt in bithsares/memo.py has invalid type annotation.

    def decrypt(self, memo):
        """ Decrypt a memo

            :param str memo: encrypted memo message
            :returns: encrypted memo
            :rtype: str
        """

Here it says that memo should be str, but it used like a dict

return BtsMemo.decode_memo(
            PrivateKey(memo_wif),
            PublicKey(
                self.from_account["options"]["memo_key"],
                prefix=self.bitshares.rpc.chain_params["prefix"]
            ),
            memo.get("nonce"),
            memo.get("message")
        )
@Algruun Algruun changed the title Invalid type annotation Invalid Memo.decrypt() type annotation Dec 7, 2018
@xeroc xeroc closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants