Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP 29: graceful connection termination #84

Open
povilasb opened this Issue May 4, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@povilasb
Copy link

povilasb commented May 4, 2018

http://www.bittorrent.org/beps/bep_0029.html doesn't specify how we should gracefully shutdown two way uTP communication.
Is it similar to TCP?
image
where

  1. Peer1 sends Fin
  2. Peer2 sends Ack
  3. Peer1 waits for Fin
  4. Peer2 sends Fin
  5. Peer1 sends Ack
@povilasb

This comment has been minimized.

Copy link
Author

povilasb commented May 7, 2018

I reviewed https://github.com/bittorrent/libutp and indeed it seems like it works just like TCP. Except I'm not sure about timeouts...
You guys mind if I make a PR to BEP 29 and specify the graceful connection shutdown process?
I believe that would disambiguate connection termination for other developers :)

@ssiloti

This comment has been minimized.

Copy link
Contributor

ssiloti commented May 11, 2018

patches welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.