avoid redundant memcopy in node_buffer::get_nodes #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
node-buffer_optimization
branch
from
cbfcd51 to
0b11328
Compare
|
rebased. travis: https://travis-ci.org/arvidn/bootstrap-dht/builds/154209715 |
| { | ||
| std::string ret; | ||
|
|
||
| if (m_buffer.size() < num_nodes) |
There was a problem hiding this comment.
This comparison should be <=. No point in returning two ranges if they're going to comprise the entire buffer.
|
lgtm |
|
actually, changing that comparison operator made the unit test fail. I'll fix that in-place in the master branch (since I already merged it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of heap allocating a string and copying nodes into, this patch makes node_buffer::get_nodes() return 2 ranges of bytes to be copied into the packet. This avoids heap allocations entirely and saves at least one memcopy for all node data.