New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only advance the read cursor by one node when returning nodes #27

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@arvidn
Contributor

arvidn commented Aug 24, 2016

to maximize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.

Does this make sense?

only advance the read cursor by one node when returning nodes, to max…
…imize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.
@arvidn

This comment has been minimized.

Show comment
Hide comment
Contributor

arvidn commented Aug 24, 2016

@ssiloti

This comment has been minimized.

Show comment
Hide comment
@ssiloti

ssiloti Aug 24, 2016

Contributor

Doesn't seem worth it to me. Prefetch should hide most of the latency here and the transfer rate is nowhere near the memory bandwidth of a modern server. The node buffer shouldn't be getting evicted to disk during normal operation either.

Contributor

ssiloti commented Aug 24, 2016

Doesn't seem worth it to me. Prefetch should hide most of the latency here and the transfer rate is nowhere near the memory bandwidth of a modern server. The node buffer shouldn't be getting evicted to disk during normal operation either.

@ssiloti ssiloti closed this Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment