only advance the read cursor by one node when returning nodes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.
|
Doesn't seem worth it to me. Prefetch should hide most of the latency here and the transfer rate is nowhere near the memory bandwidth of a modern server. The node buffer shouldn't be getting evicted to disk during normal operation either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to maximize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.
Does this make sense?