only advance the read cursor by one node when returning nodes #27

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@arvidn
Contributor
arvidn commented Aug 24, 2016

to maximize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.

Does this make sense?

@arvidn arvidn only advance the read cursor by one node when returning nodes, to max…
…imize the memory cache utilization. This is especially useful when serving nodes from a node buffer that gets evicted to disk.
72c0097
@ssiloti
Contributor
ssiloti commented Aug 24, 2016

Doesn't seem worth it to me. Prefetch should hide most of the latency here and the transfer rate is nowhere near the memory bandwidth of a modern server. The node buffer shouldn't be getting evicted to disk during normal operation either.

@ssiloti ssiloti closed this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment