Remove --without-common_test flag #3
Merged
Conversation
It prevents from compiling `rabbit_common`
I'm willing to merge this, but just be aware that if you see this, it's because the library author failed to use |
I'll get a new version of the image pushed as well |
Thanks for the explanation! I'll have a look at the missing Btw, I've noticed too late that I forgot to bump the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi Paul,
First be aware that I'm not yet very familiar with building Erlang.
We've been facing issues while compiling rabbitmq dependencies when working with Elixir
After investigating, we've found that it boils down to
common_tests
being skipped when Erlang is compiled inalpine-erlang
. Re-adding leads to just a 3mb larger image.I don't know if that makes sense to merge this, given my understanding is:
distillery
thanks for writing itcommon_test
included and then just placing the release in the docker image.alpine-erlang
we'd hit the same problem (it's simpler to build releases in docker images and copying it in another one than having to deal with OTP versions directly on our building machines).