Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between two versions of the start_erl.data #693

Open
joshchernoff opened this issue Jul 2, 2019 · 7 comments

Comments

@joshchernoff
Copy link

commented Jul 2, 2019

Steps to reproduce

Not 100% sure since our deployment process is complex.

Just a brief list of the steps required to produce the issue.
I'm seeing a discrepancy between the two start_erl.data files.

/opt/my_app/releases/start_erl.data shows correctly
/opt/insights/var/start_erl.data has a git commit sha that is a few commits back.

I found this as a result of trying to run a migration script that called on
/opt/myapp/bin/myapp_rc_exec.sh

I have found this issue only after this commit #670
4ebfe9a#diff-bb0b28dac91fa3fff22ffea720be6334

Any advice as to the difference between the two versions of start_erl.data and what is the reasoning behind the code below is would be greatly appreciated.

RELEASE_MUTABLE_DIR="${RELEASE_MUTABLE_DIR:-"${RELEASE_ROOT_DIR}/var"}"
if [ ! -f "${START_ERL_DATA}" ]; then
    mkdir -p $RELEASE_MUTABLE_DIR
    cp "${RELEASES_DIR}/start_erl.data" "${START_ERL_DATA}"
fi
@joshchernoff

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

I believe that I understand how I end up with a discrepancy between the two files because a prior deployment had not cleaned up the start_erl and thus the if condition never failed. Simply cleaning up the prior start_erl file would have fixed this issue for me. Even still I don't understand the need for looking in the mutable directory first.

@rhruiz

This comment has been minimized.

Copy link

commented Jul 11, 2019

The mentioned change seems to have broken REALEASE_READ_ONLY too. It writes start_erl.data to $RELEASE_MUTABLE_DIR even when read only is set.

@romaluca

This comment has been minimized.

Copy link

commented Jul 17, 2019

I have the same issue

@sumerman

This comment has been minimized.

Copy link

commented Jul 26, 2019

Same here

@secoint

This comment has been minimized.

Copy link

commented Aug 1, 2019

Same issue

@zazaian

This comment has been minimized.

Copy link

commented Aug 1, 2019

Also a problem for me. I've commented on a related issue in the edeliver repository but I suspect this issue lies with Distillery.

@4xposed

This comment has been minimized.

Copy link

commented Aug 12, 2019

same here

adkron added a commit to adkron/distillery that referenced this issue Aug 16, 2019

Always update start_erl.data
The start_erl.data file is not getting updated to the newest version.
This means that when starting the application an old version is
actually starting up.

Closes bitwalker#693 

Amos King @adkron <amos@binarynoggin.com>
@adkron adkron referenced a pull request that will close this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.