Fix action button disable css #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color and/or opacity is used to delineate enabled vs disabled elements. Both are required becaus some themes do not change color on disabled.
kspearrin
approved these changes
Jan 25, 2021
cscharf
pushed a commit
that referenced
this pull request
Jan 25, 2021
* Darken light theme to comply with WCAG AA * Adjust opacity on disabled Color and/or opacity is used to delineate enabled vs disabled elements. Both are required becaus some themes do not change color on disabled.
|
The buttons are now correctly grayed out but the pointing hand still appears when I mouse-over. I noticed that this also happens with other items, e.g. if no password or card security code is assigned. Is it possible to fix this? Edit: This seems to be fixed with 1.49.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1550
Action-button does not sufficiently alter action-box buttons that are disabled. This introduces new theme variable disabledOpacity to allow setting opacity of disabled object. Unfortunately, not all disabled elements look good with the same color/opacity combinations, so this isn't applied to all
&[disabled]rules.I've also darkened the action-button for the light theme to comply with WCAG AA standards. Because light uses a new color to denote a button is disabled, opacity is set to 1. Other themes don't do this so they differentiate through opacity.
Files changed
screen shots
Light
Dark
Nord