Fix Send Options Toggling #2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisonbeck
force-pushed
the
SendOptionsBug
branch
from
1431247 to
061708c
Compare
djsmith85
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://app.asana.com/0/1200578627114106/1200719554428334/f
Issue
In web and desktop we use the HTML attribute
hiddento toggle optional Send fields in and out of view. In browser we anomalously achieve this same functionality with an*ngIf.*ngIfnot loading content into the DOM until its condition is met is causing theefflux-dates-componentto not emit the initial deletion date value, resulting in an error.Solution
Change the
*ngIfto[hidden]for toggling Send optional fields on and off so form content is not added to or removed from the DOM dynamically.