-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership #9431
Merged
cagonzalezcs
merged 8 commits into
main
from
autofill/pm-8498-move-fido2-content-script-code-to-autofill-team
Jun 7, 2024
Merged
[PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership #9431
cagonzalezcs
merged 8 commits into
main
from
autofill/pm-8498-move-fido2-content-script-code-to-autofill-team
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9431 +/- ##
=======================================
Coverage 28.18% 28.18%
=======================================
Files 2434 2434
Lines 71663 71663
Branches 13394 13394
=======================================
Hits 20195 20195
Misses 49875 49875
Partials 1593 1593 ☔ View full report in Codecov by Sentry. |
New Issues
|
…ode-to-autofill-team
…ode-to-autofill-team
…ode-to-autofill-team
jprusik
approved these changes
Jun 6, 2024
…ode-to-autofill-team
…ode-to-autofill-team
gbubemismith
approved these changes
Jun 7, 2024
cyprain-okeke
pushed a commit
that referenced
this pull request
Jun 10, 2024
…ofill ownership (#9431) * [PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership * [PM-8498] Adjusting jest test reference for webauth-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8498
📔 Objective
Moving the
Fido2Background
class and content scripts specific to Fido2 behavior to Autofill team ownership.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes