Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership #9431

Conversation

cagonzalezcs
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8498

📔 Objective

Moving the Fido2Background class and content scripts specific to Fido2 behavior to Autofill team ownership.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cagonzalezcs cagonzalezcs requested review from a team as code owners May 30, 2024 14:05
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.18%. Comparing base (28e8f8f) to head (6ac35d3).

Files Patch % Lines
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9431   +/-   ##
=======================================
  Coverage   28.18%   28.18%           
=======================================
  Files        2434     2434           
  Lines       71663    71663           
  Branches    13394    13394           
=======================================
  Hits        20195    20195           
  Misses      49875    49875           
  Partials     1593     1593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 30, 2024

Logo
Checkmarx One – Scan Summary & Detailsd8938770-1fe9-4e61-b861-3bad90643c23

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html: [1](https://github.com/bitwarden/clients/blob/autofill/pm-8498-move-fido2-content-script-code-to-autofill-team//apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html# L1) Attack Vector

@cagonzalezcs cagonzalezcs removed the needs-qa Marks a PR as requiring QA approval label Jun 7, 2024
@cagonzalezcs cagonzalezcs merged commit d30b947 into main Jun 7, 2024
25 of 26 checks passed
@cagonzalezcs cagonzalezcs deleted the autofill/pm-8498-move-fido2-content-script-code-to-autofill-team branch June 7, 2024 13:47
cyprain-okeke pushed a commit that referenced this pull request Jun 10, 2024
…ofill ownership (#9431)

* [PM-8498] Moving content script-specific FIDO2 code from Vault to Autofill ownership

* [PM-8498] Adjusting jest test reference for webauth-utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants