Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1293] Add the ability to fetch a secret's access policies #9463

Merged
merged 24 commits into from
Jun 7, 2024

Conversation

Thomas-Avery
Copy link
Contributor

@Thomas-Avery Thomas-Avery commented May 31, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1293

📔 Objective

The objective of this PR is to add the ability to fetch a secret's access policies.
This change includes consolidating access policy response models so they can be used for secret access policies

Server PR: bitwarden/server#4146

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 38.94737% with 58 lines in your changes missing coverage. Please review.

Project coverage is 28.31%. Comparing base (769d67a) to head (dfa152d).

Files Patch % Lines
...er/shared/access-policies/access-policy.service.ts 0.00% 25 Missing ⚠️
...odels/responses/secret-access-policies.response.ts 0.00% 12 Missing ⚠️
...olicies/models/responses/access-policy.response.ts 0.00% 6 Missing ⚠️
...sponses/project-people-access-policies.response.ts 0.00% 3 Missing ⚠️
...service-account-people-access-policies.response.ts 0.00% 3 Missing ⚠️
...oject-service-accounts-access-policies.response.ts 0.00% 2 Missing ⚠️
...nt-granted-policies-permission-details.response.ts 0.00% 2 Missing ⚠️
...nager/projects/project/project-people.component.ts 0.00% 1 Missing ⚠️
...ects/project/project-service-accounts.component.ts 0.00% 1 Missing ⚠️
...ccounts/people/service-account-people.component.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9463      +/-   ##
==========================================
+ Coverage   28.17%   28.31%   +0.13%     
==========================================
  Files        2435     2437       +2     
  Lines       71688    71641      -47     
  Branches    13396    13396              
==========================================
+ Hits        20195    20282      +87     
+ Misses      49900    49765     -135     
- Partials     1593     1594       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 31, 2024

Logo
Checkmarx One – Scan Summary & Details43914b87-cd89-4d6e-a4d2-3af649392275

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/sm/sm-1293//apps/web/src/app/tools/password-generator-history.component.html# L11) Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/sm/sm-1293//apps/web/src/app/tools/password-generator-history.component.html# L11) Attack Vector
MEDIUM Client_Privacy_Violation /libs/components/src/color-password/color-password.component.ts: [26](https://github.com/bitwarden/clients/blob/sm/sm-1293//libs/components/src/color-password/color-password.component.ts# L26) Attack Vector

@Thomas-Avery Thomas-Avery marked this pull request as ready for review June 3, 2024 22:18
@Thomas-Avery Thomas-Avery requested a review from a team as a code owner June 3, 2024 22:18
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to approve, but i wonder why this is not being merged to main branch ?
The sm/sm-1292 does not seem to be correct "feature branch".

@Thomas-Avery
Copy link
Contributor Author

happy to approve, but i wonder why this is not being merged to main branch ? The sm/sm-1292 does not seem to be correct "feature branch".

I plan on targeting both client and server SM-1293 branches for the work in SM-654.
I'll need the work done in SM-1292 for SM-654.

mzieniukbw
mzieniukbw previously approved these changes Jun 5, 2024
@Thomas-Avery Thomas-Avery removed the needs-qa Marks a PR as requiring QA approval label Jun 7, 2024
Base automatically changed from sm/sm-1292 to main June 7, 2024 15:32
@Thomas-Avery Thomas-Avery dismissed mzieniukbw’s stale review June 7, 2024 15:32

The base branch was changed.

@Thomas-Avery Thomas-Avery merged commit 7acc13c into main Jun 7, 2024
15 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-1293 branch June 7, 2024 17:08
cyprain-okeke pushed a commit that referenced this pull request Jun 10, 2024
* Update response models

* Update view models

* Update access policy service

* update ap item types to use new models

* add convertToSecretAccessPolicies

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants