-
Notifications
You must be signed in to change notification settings - Fork 79
[PM-26064] Move BitwardenMenuField to BitwardenKit #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
06da152 to
021cb09
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 81.33% 75.76% -5.57%
==========================================
Files 831 1017 +186
Lines 52451 61992 +9541
==========================================
+ Hits 42662 46970 +4308
- Misses 9789 15022 +5233 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although it seems to have merge conflicts with main.
Ah, yeah, probably from the lint PR. I'll circle back on them. |
c43f369 to
6fdcdb8
Compare
6fdcdb8 to
c22b84b
Compare

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26064
📔 Objective
This moves the
BitwardenMenuFieldcomponent intoBitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates this component in BWA.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes