Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

📔 Objective

This moves the BitwardenMenuField component into BitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates this component in BWA.

📸 Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-02 at 08 48 29 Simulator Screenshot - iPhone 17 Pro - 2025-10-02 at 10 55 09

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode added the hold This shouldn't be merged yet label Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Logo
Checkmarx One – Scan Summary & Details8f4b39b6-56b9-436f-bdcf-9f10b1871c4f

Great job! No new security vulnerabilities introduced in this pull request

@KatherineInCode KatherineInCode force-pushed the pm-26064/bitwarden-menu-field branch from 06da152 to 021cb09 Compare October 2, 2025 16:07
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.76%. Comparing base (cb17d21) to head (c22b84b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...torShared/Core/Platform/Models/Enum/AppTheme.swift 50.00% 1 Missing ⚠️
...denShared/Core/Platform/Models/Enum/AppTheme.swift 50.00% 1 Missing ⚠️
...wardenShared/Core/Tools/Models/Enum/SendType.swift 0.00% 1 Missing ⚠️
...red/Core/Vault/Extensions/BitwardenSdk+Vault.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2012      +/-   ##
==========================================
- Coverage   81.33%   75.76%   -5.57%     
==========================================
  Files         831     1017     +186     
  Lines       52451    61992    +9541     
==========================================
+ Hits        42662    46970    +4308     
- Misses       9789    15022    +5233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from pm-26064/bitwarden-text-field to main October 6, 2025 16:34
@KatherineInCode KatherineInCode marked this pull request as ready for review October 6, 2025 16:35
@KatherineInCode KatherineInCode requested review from a team and matt-livefront as code owners October 6, 2025 16:35
@KatherineInCode KatherineInCode removed the hold This shouldn't be merged yet label Oct 6, 2025
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although it seems to have merge conflicts with main.

@KatherineInCode
Copy link
Contributor Author

Looks good, although it seems to have merge conflicts with main.

Ah, yeah, probably from the lint PR. I'll circle back on them.

@KatherineInCode KatherineInCode force-pushed the pm-26064/bitwarden-menu-field branch from c43f369 to 6fdcdb8 Compare October 6, 2025 21:05
@KatherineInCode KatherineInCode force-pushed the pm-26064/bitwarden-menu-field branch from 6fdcdb8 to c22b84b Compare October 6, 2025 21:12
@KatherineInCode KatherineInCode merged commit 2cf0293 into main Oct 7, 2025
13 of 14 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/bitwarden-menu-field branch October 7, 2025 13:52
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants