Skip to content

Conversation

@vvolkgang
Copy link
Member

@vvolkgang vvolkgang commented Oct 2, 2025

🎟️ Tracking

PM-26160

📔 Objective

  • Pre-boot iOS Simulator
  • Split Build and Test steps - each step now creates it's own .xcresult file
  • 🤠 pyeetd
    • Add error handling, fixes race condition where processes would shutdown between retrieving the processes list and killing it.
    • While testing found additional processes taking CPU% but didn't have enough time to test if it decreases runtime, commented them out for the time being.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsb15dbe3c-e22a-4323-b55e-72cb734d5b61

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang force-pushed the vvolkgang/test-timeout branch from 4be06c9 to f9ca241 Compare October 6, 2025 14:44
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.78%. Comparing base (db7cca7) to head (4cf0381).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   81.24%   75.78%   -5.47%     
==========================================
  Files         825     1018     +193     
  Lines       52190    62052    +9862     
==========================================
+ Hits        42404    47028    +4624     
- Misses       9786    15024    +5238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang vvolkgang changed the title Optimize macOS CI runners with process monitoring and build/test split [PM-26160] Optimize macOS CI runners with process monitoring and build/test split Oct 7, 2025
@vvolkgang vvolkgang marked this pull request as ready for review October 7, 2025 13:37
@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners October 7, 2025 13:37
@vvolkgang vvolkgang requested a review from a team as a code owner October 7, 2025 13:37
@vvolkgang vvolkgang changed the title [PM-26160] Optimize macOS CI runners with process monitoring and build/test split [PM-26160] Test workflows - Split Build / Test steps and pre-boot simulator Oct 7, 2025
@vvolkgang vvolkgang added the t:ci Updates to automated workflows label Oct 7, 2025
@vvolkgang vvolkgang enabled auto-merge (squash) October 7, 2025 13:43
@vvolkgang vvolkgang merged commit 327d949 into main Oct 7, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/test-timeout branch October 7, 2025 13:50
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants