Skip to content

Conversation

@KatherineInCode
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-26064

๐Ÿ“” Objective

This consolidates form fields to BitwardenKit, as part of a broader effort to move our various components into BitwardenKit. This also updates the components in BWA.

๐Ÿ“ธ Screenshots

Before After
Simulator Screenshot - iPhone 17 Pro - 2025-10-10 at 14 01 11 Simulator Screenshot - iPhone 17 Pro - 2025-10-10 at 14 02 38

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ d074d8f8-e7f0-4648-a11a-69820059b278

Great job! No new security vulnerabilities introduced in this pull request

@KatherineInCode KatherineInCode marked this pull request as ready for review October 10, 2025 19:38
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

โŒ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
โš ๏ธ Please upload report for BASE (main@07176cd). Learn more about missing BASE report.
โš ๏ธ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...plication/Views/FormFields/FormMenuFieldView.swift 50.00% 1 Missing โš ๏ธ
...plication/Views/FormFields/FormTextFieldView.swift 50.00% 1 Missing โš ๏ธ
...Application/Views/FormFields/SliderFieldView.swift 90.90% 1 Missing โš ๏ธ
...pplication/Views/FormFields/StepperFieldView.swift 90.00% 1 Missing โš ๏ธ
...Application/Views/FormFields/ToggleFieldView.swift 90.90% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2032   +/-   ##
=======================================
  Coverage        ?   82.88%           
=======================================
  Files           ?     1998           
  Lines           ?   160939           
  Branches        ?        0           
=======================================
  Hits            ?   133387           
  Misses          ?    27552           
  Partials        ?        0           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode merged commit af42bd4 into main Oct 10, 2025
12 checks passed
@KatherineInCode KatherineInCode deleted the pm-26064/form-fields branch October 10, 2025 20:03
kevinrossen pushed a commit to kevinrossen/bitwarden_ios that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants