From fdc6f7b1d234c72724db47cbea6c94bff7ec0106 Mon Sep 17 00:00:00 2001 From: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Date: Tue, 8 Jun 2021 14:35:03 -0700 Subject: [PATCH] Refactor canactivate guards (#401) * Refactor route guards to allow for subclassing * fix linting --- angular/src/services/lock-guard.service.ts | 4 +++- angular/src/services/unauth-guard.service.ts | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/angular/src/services/lock-guard.service.ts b/angular/src/services/lock-guard.service.ts index ae5d60d72..400eedc55 100644 --- a/angular/src/services/lock-guard.service.ts +++ b/angular/src/services/lock-guard.service.ts @@ -9,6 +9,8 @@ import { VaultTimeoutService } from 'jslib-common/abstractions/vaultTimeout.serv @Injectable() export class LockGuardService implements CanActivate { + + protected homepage = 'vault'; constructor(private vaultTimeoutService: VaultTimeoutService, private userService: UserService, private router: Router) { } @@ -19,7 +21,7 @@ export class LockGuardService implements CanActivate { if (locked) { return true; } else { - this.router.navigate(['vault']); + this.router.navigate([this.homepage]); return false; } } diff --git a/angular/src/services/unauth-guard.service.ts b/angular/src/services/unauth-guard.service.ts index 3628efd94..786241b88 100644 --- a/angular/src/services/unauth-guard.service.ts +++ b/angular/src/services/unauth-guard.service.ts @@ -1,5 +1,6 @@ import { Injectable } from '@angular/core'; import { + ActivatedRouteSnapshot, CanActivate, Router, } from '@angular/router'; @@ -9,6 +10,8 @@ import { VaultTimeoutService } from 'jslib-common/abstractions/vaultTimeout.serv @Injectable() export class UnauthGuardService implements CanActivate { + + protected homepage = 'vault'; constructor(private vaultTimeoutService: VaultTimeoutService, private userService: UserService, private router: Router) { } @@ -19,7 +22,7 @@ export class UnauthGuardService implements CanActivate { if (locked) { this.router.navigate(['lock']); } else { - this.router.navigate(['vault']); + this.router.navigate([this.homepage]); } return false; }