[PM-1615] Fix cipher options not working in lists due to binding failing #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g due to type mismatch. Updated GroupingsPageViewModel to new way of calling as well
mpbw2
approved these changes
Mar 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
1 task
1 task
|
@fedemkr Thanks for the fix. When is the release due date with that merge ? |
|
Hi @roniaxe sorry for the delayed answer, but yes this fix is already in production since v2023.4.0. Let us know if you still have any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix cipher options not working on lists due to binding failing.
#2456 again so it gets tested before merged to master
Code changes
ButtonCommandfromCommand<CipherView>toICommandto make it more generic and easy to bind to any type of command in the ViewModel. This was causing the issue due to the change on the ViewModel to anAsyncCommand<...>AsyncCommand<...>as in the other places.Before you submit
dotnet format --verify-no-changes) (required)