[PM-3152] Add autofill support for cromite

[Bahasnyldz]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

Bitwarden autofill doesn't work in cromite
Cromite is fork of bromite aims to privacy and security.

Code changes

• AutofillHelpers.cs: Added "org.cromite.cromite",
• AccessibilityHelpers.cs: Added new Browser("org.cromite.cromite", "url_bar"),
• autofillservice.xml Added <compatibility-package android:name="org.cromite.cromite" android:maxLongVersionCode="10000000000"/>

Screenshots

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[CLAassistant]

All committers have signed the CLA.

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-3152

[srappan]

Hiya has their been any movement to merge this?

Thanks in advance

[unoukujou]

Hello. Why is it taking over a month to fix such a simple thing? Not to be pushy but come on guys, it has been a pain to use bitwarden without this feature and I have to resort to insecure copy & pasting. I mean, for such a small simple thing, just add it and let's move on. Thanks

[unoukujou]

@djsmith85 what does it mean:

Merging is blocked
Merging can be performed automatically with 1 approving review.

Are you able to approve it? If so, thanks! I'm going crazy without being able to use autofill.

[gammaray05]

Yes please, there's an entire community of privacy oriented users that waits to use Cromite just because bitwarden can't be used.

[uazo]

in any case, i don't think these changes are the correct ones.
cromite (like bromite, that patch I made) natively supports android autofill, so I think it goes in the TrustedBrowsers list rather than CompatBrowsers.
Obviously it has to be checked.

[varaki]

@djsmith85 what does it mean:

Merging is blocked Merging can be performed automatically with 1 approving review.

Are you able to approve it? If so, thanks! I'm going crazy without being able to use autofill.

Until it's finally fixed, you can resort to manually searching your vault using the magnifying glass on the top right corner of the page that shows the "There are no items in your vault for org.cromite.cromite" message, then tap on the correct search result, then select Auto-fill. It's a bit cumbersome, but at least you can avoid copypasting.

[unoukujou]

@djsmith85 what does it mean:
Merging is blocked Merging can be performed automatically with 1 approving review.
Are you able to approve it? If so, thanks! I'm going crazy without being able to use autofill.

Until it's finally fixed, you can resort to manually searching your vault using the magnifying glass on the top right corner of the page that shows the "There are no items in your vault for org.cromite.cromite" message, then tap on the correct search result, then select Auto-fill. It's a bit cumbersome, but at least you can avoid copypasting.

Thanks, I'll try that way. But it's also a bigger problem to save new logins. Bitwarden doesn't offer to save the new logins and I have to enter everything manually.

[varaki]

Any updates?

[chris122380]

Doesn't work on Bitwarden 2023.9.1

[unoukujou]

Doesn't work on Bitwarden 2023.9.1

Still no update since 4 months.

Also Mulch browser... Same thing, 8 months waiting. Pull request has been done.

#2427
#2640
#2709
#2639

[Para-lyzed]

Since the Checkmarx check is failing, it may be necessary to recheck this PR before it is reviewed. After the Checkmarx check is successful, can you request a review @Bahasnyldz ?

Please disregard, it seems this is currently being reviewed and no changes are necessary.

[djsmith85]

Hey everyone, currently no action is needed by @Bahasnyldz. This is in review by product management.

[varaki]

Hey everyone, currently no action is needed by @Bahasnyldz. This is in review by product management.

Cool, I just really hope it won't take another few months 🙂

[fedemkr]

HI everyone, thank you for this contribution 🎉 . This has been approved and is ready for QA to test.

[solomonrajan]

Any update regarding autofill, still not working in browser.

[Para-lyzed]

This has been approved and is ready for QA to test.

@fedemkr Any update on when this will be pushed to QA? It's been a month since approval and this pull request is only 5 lines that merely specify the package name of a browser

[fedemkr]

Hi everyone, this is currently being looked at by the QA team.

[1RandomDev]

By now I just cloned the repo and built my own version of the app with the changes applied. It's ridiculous how long it takes a company as big as Bitwarden to merge 3 lines of code adding support for a browser.

[unoukujou]

By now I just cloned the repo and built my own version of the app with the changes applied. It's ridiculous how long it takes a company as big as Bitwarden to merge 3 lines of code adding support for a browser.

Plus the fact that this is also making bitwarden users less secure when we have to use copy and paste. It should be more priority especially when it's something so simple. Anyway, they're having a meeting to discuss it so that's good I guess? The sad part is that mainstream browsers that don't respect user privacy like Chrome will not have problems like this. Oh well...

[larena1]

By now I just cloned the repo and built my own version of the app with the changes applied. It's ridiculous how long it takes a company as big as Bitwarden to merge 3 lines of code adding support for a browser.

It's always been like this. They don't react on issues, they promise to look into stuff but in reality they don't, it's just sad.

Horrible and inexperienced management. It's not even clear to me what all the people are constantly working on when there's so little to see in the end.

[varaki]

Hey everyone, currently no action is needed by @Bahasnyldz. This is in review by product management.

Cool, I just really hope it won't take another few months 🙂

Aaand it did... And still nothing, just "reviews" and "discussions" repeatedly over a few lines of code.
Not good.

[differsthecat]

Hi everyone, thank you again for your patience on this. I wanted to give a quick update that we expect QA to complete their testing next week and we will update with any findings or merge if it is good to go!

[foegra]

Hi everyone, thank you again for your patience on this. I wanted to give a quick update that we expect QA to complete their testing next week and we will update with any findings or merge if it is good to go!

I really hope - You guys can find a way to add browser support quicker in the future!

[unoukujou]

@differsthecat Thanks and please don't forget about Mulch ( #2427 ). That one has been an even longer wait. Almost a year now. 😞

[larena1]

Almost a year now. 😞

Please give QA some time. There has been a regularly long delay but they'll probably pick it up not very soon.

[unoukujou]

Almost a year now. 😞

Please give QA some time. There has been a regularly long delay but they'll probably pick it up not very soon.

Ummm yeah... I think "some time" has been given, but thanks. 🙄

[fedemkr]

Hi everyone, QA has approved this so we move forward on merging this 🎉 . Thank you all for your patience and the contribution!

[larena1]

@fedemkr Thanks for sharing. It's not even been 5 months since this PR has been created so that's very good.

[rywz]

It's still the same for me, checks for org.cromite.cromite instead of the actual URL.

*using the 2023.12.0 version

[larena1]

It's still the same for me, checks for org.cromite.cromite instead of the actual URL.

*using the 2023.12.0 version

It will be in the next version in 1 or 2 months maybe. Please give it some more time. It hasn't even been 5 months yet.

[rywz]

It's still the same for me, checks for org.cromite.cromite instead of the actual URL.

*using the 2023.12.0 version

It will be in the next version in 1 or 2 months maybe. Please give it some more time. It hasn't even been 5 months yet.

ohh okay.. but just wondering: why not now? I mean it's merged already.

[larena1]

It's still the same for me, checks for org.cromite.cromite instead of the actual URL.
*using the 2023.12.0 version

It will be in the next version in 1 or 2 months maybe. Please give it some more time. It hasn't even been 5 months yet.

ohh okay.. but just wondering: why not now? I mean it's merged already.

Because at Bitwarden things are done very thoroughly and therefore take a long time.

https://github.com/bitwarden/mobile/commits/v2023.12.0

Version 2023.12.0 does not include the Cromite commit.

[unoukujou]

In the meantime though, users are less secure using copy&paste. Android keeps warning me about apps accessing my clipboard. Something so simple and straightforward as this should really be updated quickly. Especially since having it makes users more secure and gives a much better/easier user experience.

[AlaisterLeung]

Version 2023.12.1 includes the Cromite commit.
We can download the build from GitHub Actions:
https://github.com/bitwarden/mobile/actions/runs/7118767114

[netizeni]

@AlaisterLeung is it possible to download .apk file from there somewhere? I was looking, but couldn't find it.

[AlaisterLeung]

@AlaisterLeung is it possible to download .apk file from there somewhere? I was looking, but couldn't find it.

@netizeni On that page, scroll down to Artifacts and download com.x8bit.bitwarden.apk

[larena1]

@uazo this doesn't really work as expected. When logging in to Google, it'll allow to autofill the username on the first screen but not the password on the next screen - Bitwarden won't even show above the keyboard when on the password screen. In Chrome and also in Firefox, Bitwarden does work on both screens.

Could this be due to you having implemented native autofill in Cromite and not just accessibility?

[netizeni]

@netizeni On that page, scroll down to Artifacts and download com.x8bit.bitwarden.apk

Thank you! I just now notices you have to be logged in to download, I tried without login and then logged in to ask, lol.

[uazo]

Could this be due to you having implemented native autofill in Cromite and not just accessibility?

theoretically, native autofill support does not replace compatibility mode, so I don't think it's because of that.
perhaps it is related to the "Fill passwords on account selection" chrome://flags/#fill-on-account-select flag being active by default, which forces the user to click on the element to initiate autofill

[Parsnip]

Could this be due to you having implemented native autofill in Cromite and not just accessibility?

theoretically, native autofill support does not replace compatibility mode, so I don't think it's because of that. perhaps it is related to the "Fill passwords on account selection" chrome://flags/#fill-on-account-select flag being active by default, which forces the user to click on the element to initiate autofill

As far as I can see toggling that flag has no effect. For what it's worth as far as I can remember this might have been similarly broken in bromite as well.

[larena1]

@uazo do you think you can fix that maybe? It appears to happen on sites where there is just a password field like with two step login procedures where you enter the username first and then the password in the next step.

[uazo]

well, I don't know, if it's a bug then I introduced it, so I guess so.
but I need the context in a new issue in my repo, please.

[Fxzzi]

Cromite fill is available in 2024.1.0 🎉🎉

[adriy-be]

Hi everyone, thank you again for your patience on this. I wanted to give a quick update that we expect QA to complete their testing next week and we will update with any findings or merge if it is good to go!

I really hope - You guys can find a way to add browser support quicker in the future!

Totally agree !