From d0eedbc844cb9f58b23c131cd43192b32a271fa2 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Thu, 14 Aug 2025 15:55:28 -0500 Subject: [PATCH 01/11] Added not wasm config for get_ancestors --- crates/bitwarden-vault/src/collection_client.rs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 80e092df3..c3a6150c8 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -1,3 +1,6 @@ +#[cfg(not(feature = "wasm"))] +use std::collections::HashMap; + use bitwarden_collections::{ collection::{Collection, CollectionView}, tree::{NodeItem, Tree}, @@ -80,6 +83,15 @@ impl CollectionViewNodeItem { map }) } + + #[cfg(not(feature = "wasm"))] + pub fn get_ancestors(&self) -> HashMap { + self.node_item + .ancestors + .iter() + .map(|(id, name)| (id.to_string(), name.to_string())) + .collect() + } } #[cfg_attr(feature = "wasm", wasm_bindgen)] From 4cb672d614ca8fb1223b787076d42c54841ba6a4 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Fri, 15 Aug 2025 08:31:08 -0500 Subject: [PATCH 02/11] Creating a struct to wrap HashMap --- .../bitwarden-vault/src/collection_client.rs | 34 +++++++------------ 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index c3a6150c8..f196afcfb 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -1,14 +1,13 @@ -#[cfg(not(feature = "wasm"))] use std::collections::HashMap; - +use serde::{Deserialize, Serialize}; +use tsify::Tsify; +use uuid::Uuid; use bitwarden_collections::{ collection::{Collection, CollectionView}, tree::{NodeItem, Tree}, }; use bitwarden_core::Client; #[cfg(feature = "wasm")] -use bitwarden_error::js_sys::Map; -#[cfg(feature = "wasm")] use wasm_bindgen::prelude::wasm_bindgen; use crate::DecryptError; @@ -73,25 +72,18 @@ impl CollectionViewNodeItem { self.node_item.children.clone() } - #[cfg(feature = "wasm")] - pub fn get_ancestors(&self) -> Map { - self.node_item - .ancestors - .iter() - .fold(Map::new(), |map, (id, name)| { - map.set(&id.to_string().into(), &name.into()); - map - }) + pub fn get_ancestors(&self) -> AncestorMap { + AncestorMap { + ancestors: self.node_item.ancestors.clone(), + } } +} - #[cfg(not(feature = "wasm"))] - pub fn get_ancestors(&self) -> HashMap { - self.node_item - .ancestors - .iter() - .map(|(id, name)| (id.to_string(), name.to_string())) - .collect() - } +#[derive(Serialize, Deserialize, Tsify)] +#[tsify(into_wasm_abi, from_wasm_abi)] +pub struct AncestorMap { + #[serde(flatten)] + ancestors: HashMap, } #[cfg_attr(feature = "wasm", wasm_bindgen)] From d8dea97a3786c8de67ca3d05dce931b81341d140 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Fri, 15 Aug 2025 08:33:07 -0500 Subject: [PATCH 03/11] Linting --- crates/bitwarden-vault/src/collection_client.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index f196afcfb..5e64d1dad 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -1,12 +1,13 @@ use std::collections::HashMap; -use serde::{Deserialize, Serialize}; -use tsify::Tsify; -use uuid::Uuid; + use bitwarden_collections::{ collection::{Collection, CollectionView}, tree::{NodeItem, Tree}, }; use bitwarden_core::Client; +use serde::{Deserialize, Serialize}; +use tsify::Tsify; +use uuid::Uuid; #[cfg(feature = "wasm")] use wasm_bindgen::prelude::wasm_bindgen; From 669639d771a786953d6c65b1e6f76b6cf569b4d0 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Fri, 15 Aug 2025 09:17:37 -0500 Subject: [PATCH 04/11] Fixing feature macros. --- crates/bitwarden-vault/src/collection_client.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 5e64d1dad..451e0550c 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -6,6 +6,7 @@ use bitwarden_collections::{ }; use bitwarden_core::Client; use serde::{Deserialize, Serialize}; +#[cfg(feature = "wasm")] use tsify::Tsify; use uuid::Uuid; #[cfg(feature = "wasm")] @@ -80,10 +81,9 @@ impl CollectionViewNodeItem { } } -#[derive(Serialize, Deserialize, Tsify)] -#[tsify(into_wasm_abi, from_wasm_abi)] +#[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] +#[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] pub struct AncestorMap { - #[serde(flatten)] ancestors: HashMap, } From 65be6358a04b609f5431e105a7c3a352765e36da Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Wed, 20 Aug 2025 09:19:16 -0500 Subject: [PATCH 05/11] Added uniffi bindings to collection_client --- .../bitwarden-uniffi/src/vault/collections.rs | 64 ++----------------- .../bitwarden-vault/src/collection_client.rs | 17 +++-- 2 files changed, 16 insertions(+), 65 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index 77eb381f6..9d06830db 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -1,12 +1,8 @@ -use std::{collections::HashMap, sync::Arc}; - -use bitwarden_collections::{ - collection::{Collection, CollectionView}, - tree::{NodeItem, Tree}, -}; -use uuid::Uuid; +use std::sync::Arc; use crate::{error::Error, Result}; +use bitwarden_collections::collection::{Collection, CollectionView}; +use bitwarden_vault::collection_client::CollectionViewTree; #[allow(missing_docs)] #[derive(uniffi::Object)] @@ -28,56 +24,6 @@ impl CollectionsClient { /// Returns the vector of CollectionView objects in a tree structure based on its implemented /// path(). pub fn get_collection_tree(&self, collections: Vec) -> Arc { - Arc::new(CollectionViewTree { - tree: Tree::from_items(collections), - }) - } -} - -#[derive(uniffi::Object)] -pub struct CollectionViewTree { - tree: Tree, -} - -#[derive(uniffi::Object)] -#[allow(unused)] -pub struct CollectionViewNodeItem { - node_item: NodeItem, -} - -#[uniffi::export] -impl CollectionViewTree { - pub fn get_item_by_id(&self, collection_id: Uuid) -> Option> { - self.tree - .get_item_by_id(collection_id) - .map(|n| Arc::new(CollectionViewNodeItem { node_item: n })) - } - - pub fn get_root_items(&self) -> Vec> { - self.tree - .nodes - .iter() - .filter(|n| n.parent_idx.is_none()) - .filter_map(|n| self.get_item_by_id(n.item_id)) - .collect() - } -} - -#[uniffi::export] -impl CollectionViewNodeItem { - pub fn get_item(&self) -> CollectionView { - self.node_item.item.clone() - } - - pub fn get_parent(&self) -> Option { - self.node_item.parent.clone() - } - - pub fn get_children(&self) -> Vec { - self.node_item.children.clone() - } - - pub fn get_ancestors(&self) -> HashMap { - self.node_item.ancestors.clone() + Arc::new(self.0.get_collection_tree(collections)) } -} +} \ No newline at end of file diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 451e0550c..528c62173 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -12,6 +12,8 @@ use uuid::Uuid; #[cfg(feature = "wasm")] use wasm_bindgen::prelude::wasm_bindgen; +#[cfg(feature = "uniffi")] +use uniffi; use crate::DecryptError; #[allow(missing_docs)] @@ -51,15 +53,24 @@ impl CollectionsClient { } #[cfg_attr(feature = "wasm", wasm_bindgen)] +#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] pub struct CollectionViewTree { tree: Tree, } #[cfg_attr(feature = "wasm", wasm_bindgen)] +#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] pub struct CollectionViewNodeItem { node_item: NodeItem, } +#[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] +#[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] +#[cfg_attr(feature = "uniffi", derive(uniffi::Record))] +pub struct AncestorMap { + ancestors: HashMap, +} + #[cfg_attr(feature = "wasm", wasm_bindgen)] impl CollectionViewNodeItem { pub fn get_item(&self) -> CollectionView { @@ -81,12 +92,6 @@ impl CollectionViewNodeItem { } } -#[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] -#[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] -pub struct AncestorMap { - ancestors: HashMap, -} - #[cfg_attr(feature = "wasm", wasm_bindgen)] impl CollectionViewTree { pub fn get_item_by_id( From 3f9f4b20c95bf7bcf74e7e62e0fb656147f4dc6d Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Wed, 20 Aug 2025 09:21:02 -0500 Subject: [PATCH 06/11] linting --- crates/bitwarden-uniffi/src/vault/collections.rs | 5 +++-- crates/bitwarden-vault/src/collection_client.rs | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index 9d06830db..9da4403ac 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -1,9 +1,10 @@ use std::sync::Arc; -use crate::{error::Error, Result}; use bitwarden_collections::collection::{Collection, CollectionView}; use bitwarden_vault::collection_client::CollectionViewTree; +use crate::{error::Error, Result}; + #[allow(missing_docs)] #[derive(uniffi::Object)] pub struct CollectionsClient(pub(crate) bitwarden_vault::collection_client::CollectionsClient); @@ -26,4 +27,4 @@ impl CollectionsClient { pub fn get_collection_tree(&self, collections: Vec) -> Arc { Arc::new(self.0.get_collection_tree(collections)) } -} \ No newline at end of file +} diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 528c62173..6db0b57b6 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -8,12 +8,12 @@ use bitwarden_core::Client; use serde::{Deserialize, Serialize}; #[cfg(feature = "wasm")] use tsify::Tsify; +#[cfg(feature = "uniffi")] +use uniffi; use uuid::Uuid; #[cfg(feature = "wasm")] use wasm_bindgen::prelude::wasm_bindgen; -#[cfg(feature = "uniffi")] -use uniffi; use crate::DecryptError; #[allow(missing_docs)] From 464f6978118a7af8f6e0e65b98498bf5b98cf1a4 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Wed, 17 Sep 2025 11:54:25 -0500 Subject: [PATCH 07/11] Adding export to impl blocks --- crates/bitwarden-vault/src/collection_client.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 15a3a3e70..a0a40edf3 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -72,6 +72,7 @@ pub struct AncestorMap { } #[cfg_attr(feature = "wasm", wasm_bindgen)] +#[cfg_attr(feature = "uniffi", uniffi::export)] impl CollectionViewNodeItem { pub fn get_item(&self) -> CollectionView { self.node_item.item.clone() @@ -93,6 +94,7 @@ impl CollectionViewNodeItem { } #[cfg_attr(feature = "wasm", wasm_bindgen)] +#[cfg_attr(feature = "uniffi", uniffi::export)] impl CollectionViewTree { pub fn get_item_by_id( &self, From 81619732608531387a7df27d51b77c7cd185b453 Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Fri, 19 Sep 2025 10:59:35 -0500 Subject: [PATCH 08/11] Adding uniffi specific implementations for CollectionViewTree and CollectionViewNodeItem --- .../bitwarden-uniffi/src/vault/collections.rs | 72 +++++++++++++++++-- .../bitwarden-vault/src/collection_client.rs | 6 +- 2 files changed, 67 insertions(+), 11 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index 9da4403ac..d07f0755b 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -1,9 +1,8 @@ -use std::sync::Arc; - -use bitwarden_collections::collection::{Collection, CollectionView}; -use bitwarden_vault::collection_client::CollectionViewTree; - use crate::{error::Error, Result}; +use bitwarden_collections::collection::{Collection, CollectionView}; +use bitwarden_collections::tree::{NodeItem, Tree}; +use bitwarden_vault::collection_client::{AncestorMap}; +use std::sync::Arc; #[allow(missing_docs)] #[derive(uniffi::Object)] @@ -25,6 +24,67 @@ impl CollectionsClient { /// Returns the vector of CollectionView objects in a tree structure based on its implemented /// path(). pub fn get_collection_tree(&self, collections: Vec) -> Arc { - Arc::new(self.0.get_collection_tree(collections)) + Arc::new(CollectionViewTree { + tree: Tree::from_items(collections), + }) } } + +#[derive(uniffi::Object)] +pub struct CollectionViewTree { + tree: Tree, +} + +#[derive(uniffi::Object)] +pub struct CollectionViewNodeItem { + node_item: NodeItem, +} + +#[uniffi::export] +impl CollectionViewTree { + pub fn get_item_by_id( + &self, + collection_view: CollectionView, + ) -> Option> { + self.tree + .get_item_by_id(collection_view.id.unwrap_or_default().into()) + .map(|n| Arc::new(CollectionViewNodeItem { node_item: n })) + } + + pub fn get_root_items(&self) -> Vec> { + self.tree + .get_root_items() + .into_iter() + .map(|n| Arc::new(CollectionViewNodeItem { node_item: n })) + .collect() + } + + pub fn get_flat_items(&self) -> Vec> { + self.tree + .get_flat_items() + .into_iter() + .map(|n| Arc::new(CollectionViewNodeItem { node_item: n })) + .collect() + } +} + +#[uniffi::export] +impl CollectionViewNodeItem { + pub fn get_item(&self) -> CollectionView { + self.node_item.item.clone() + } + + pub fn get_parent(&self) -> Option { + self.node_item.parent.clone() + } + + pub fn get_children(&self) -> Vec { + self.node_item.children.clone() + } + + pub fn get_ancestors(&self) -> AncestorMap { + AncestorMap { + ancestors: self.node_item.ancestors.clone(), + } + } +} \ No newline at end of file diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index a0a40edf3..7e1f1e3c5 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -53,13 +53,11 @@ impl CollectionsClient { } #[cfg_attr(feature = "wasm", wasm_bindgen)] -#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] pub struct CollectionViewTree { tree: Tree, } #[cfg_attr(feature = "wasm", wasm_bindgen)] -#[cfg_attr(feature = "uniffi", derive(uniffi::Object))] pub struct CollectionViewNodeItem { node_item: NodeItem, } @@ -68,11 +66,10 @@ pub struct CollectionViewNodeItem { #[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] #[cfg_attr(feature = "uniffi", derive(uniffi::Record))] pub struct AncestorMap { - ancestors: HashMap, + pub ancestors: HashMap, } #[cfg_attr(feature = "wasm", wasm_bindgen)] -#[cfg_attr(feature = "uniffi", uniffi::export)] impl CollectionViewNodeItem { pub fn get_item(&self) -> CollectionView { self.node_item.item.clone() @@ -94,7 +91,6 @@ impl CollectionViewNodeItem { } #[cfg_attr(feature = "wasm", wasm_bindgen)] -#[cfg_attr(feature = "uniffi", uniffi::export)] impl CollectionViewTree { pub fn get_item_by_id( &self, From 1507425adb6603ff82b991f82db7e408407fb78b Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Fri, 19 Sep 2025 11:02:42 -0500 Subject: [PATCH 09/11] linting --- crates/bitwarden-uniffi/src/vault/collections.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index d07f0755b..af33d535f 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -1,9 +1,13 @@ -use crate::{error::Error, Result}; -use bitwarden_collections::collection::{Collection, CollectionView}; -use bitwarden_collections::tree::{NodeItem, Tree}; -use bitwarden_vault::collection_client::{AncestorMap}; use std::sync::Arc; +use bitwarden_collections::{ + collection::{Collection, CollectionView}, + tree::{NodeItem, Tree}, +}; +use bitwarden_vault::collection_client::AncestorMap; + +use crate::{error::Error, Result}; + #[allow(missing_docs)] #[derive(uniffi::Object)] pub struct CollectionsClient(pub(crate) bitwarden_vault::collection_client::CollectionsClient); @@ -87,4 +91,4 @@ impl CollectionViewNodeItem { ancestors: self.node_item.ancestors.clone(), } } -} \ No newline at end of file +} From f480f89c4c2e06a8f7deaf34688af920ed55ee1d Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Mon, 22 Sep 2025 09:27:44 -0500 Subject: [PATCH 10/11] Have ancestor map use CollectionId --- .../bitwarden-uniffi/src/vault/collections.rs | 9 ++++++-- .../bitwarden-vault/src/collection_client.rs | 21 ++++++++++++------- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index af33d535f..ee295bf7b 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -1,7 +1,7 @@ use std::sync::Arc; use bitwarden_collections::{ - collection::{Collection, CollectionView}, + collection::{Collection, CollectionId, CollectionView}, tree::{NodeItem, Tree}, }; use bitwarden_vault::collection_client::AncestorMap; @@ -88,7 +88,12 @@ impl CollectionViewNodeItem { pub fn get_ancestors(&self) -> AncestorMap { AncestorMap { - ancestors: self.node_item.ancestors.clone(), + ancestors: self + .node_item + .ancestors + .iter() + .map(|(&uuid, name)| (CollectionId::new(uuid), name.clone())) + .collect(), } } } diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 7e1f1e3c5..24397682f 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -1,16 +1,13 @@ use std::collections::HashMap; use bitwarden_collections::{ - collection::{Collection, CollectionView}, + collection::{Collection, CollectionId, CollectionView}, tree::{NodeItem, Tree}, }; use bitwarden_core::Client; use serde::{Deserialize, Serialize}; #[cfg(feature = "wasm")] use tsify::Tsify; -#[cfg(feature = "uniffi")] -use uniffi; -use uuid::Uuid; #[cfg(feature = "wasm")] use wasm_bindgen::prelude::wasm_bindgen; @@ -62,11 +59,14 @@ pub struct CollectionViewNodeItem { node_item: NodeItem, } -#[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] -#[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] +#[cfg_attr( + feature = "wasm", + derive(Tsify, Serialize, Deserialize), + tsify(into_wasm_abi, from_wasm_abi) +)] #[cfg_attr(feature = "uniffi", derive(uniffi::Record))] pub struct AncestorMap { - pub ancestors: HashMap, + pub ancestors: HashMap, } #[cfg_attr(feature = "wasm", wasm_bindgen)] @@ -85,7 +85,12 @@ impl CollectionViewNodeItem { pub fn get_ancestors(&self) -> AncestorMap { AncestorMap { - ancestors: self.node_item.ancestors.clone(), + ancestors: self + .node_item + .ancestors + .iter() + .map(|(&uuid, name)| (CollectionId::new(uuid), name.clone())) + .collect(), } } } From 789b822c536526146e89f3dd71549cf4088ca6ba Mon Sep 17 00:00:00 2001 From: jrmccannon Date: Tue, 30 Sep 2025 14:11:48 -0500 Subject: [PATCH 11/11] rename to get_item_for_view --- crates/bitwarden-uniffi/src/vault/collections.rs | 2 +- crates/bitwarden-vault/src/collection_client.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/bitwarden-uniffi/src/vault/collections.rs b/crates/bitwarden-uniffi/src/vault/collections.rs index ee295bf7b..505b747a2 100644 --- a/crates/bitwarden-uniffi/src/vault/collections.rs +++ b/crates/bitwarden-uniffi/src/vault/collections.rs @@ -46,7 +46,7 @@ pub struct CollectionViewNodeItem { #[uniffi::export] impl CollectionViewTree { - pub fn get_item_by_id( + pub fn get_item_for_view( &self, collection_view: CollectionView, ) -> Option> { diff --git a/crates/bitwarden-vault/src/collection_client.rs b/crates/bitwarden-vault/src/collection_client.rs index 24397682f..f74cf7be2 100644 --- a/crates/bitwarden-vault/src/collection_client.rs +++ b/crates/bitwarden-vault/src/collection_client.rs @@ -97,7 +97,7 @@ impl CollectionViewNodeItem { #[cfg_attr(feature = "wasm", wasm_bindgen)] impl CollectionViewTree { - pub fn get_item_by_id( + pub fn get_item_for_view( &self, collection_view: CollectionView, ) -> Option {