-
Notifications
You must be signed in to change notification settings - Fork 25
Fix vscode features #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vscode features #584
Conversation
|
Claude finished @quexten's task —— View job Code Review CompleteSummary of Changes Since Last ReviewThe PR has been updated following dani-garcia's feedback. The second commit (7515282) correctly changed the Commit progression:
Finding 1: PR Title and Description Need Improvement💭 The PR objective states "Vscode is not happy with 'all' being enabled and claims to not find it. This switches all to use 'internal' + 'wasm' instead." However, this description is now outdated—the final implementation uses Suggested improvementsTitle: No change needed - still accurate. Objective section: ## 📔 Objective
VSCode's rust-analyzer was not recognizing the `"all"` feature when specified as an array element `["all"]`. The correct syntax requires `"all"` to be specified as a plain string value. This change fixes the configuration to use the proper format: `"rust-analyzer.cargo.features": "all"`.Critical Issues FoundNone - the code change is correct and follows rust-analyzer's expected configuration format. Good Practices Observed
Action Items
|
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 302 302
Lines 32331 32331
=======================================
Hits 25691 25691
Misses 6640 6640 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>

🎟️ Tracking
📔 Objective
Vscode is not happy with "all" being enabled and claims to not find it. This switches all to use "internal" + "wasm" instead.
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes