Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Nov 26, 2025

🎟️ Tracking

📔 Objective

Vscode is not happy with "all" being enabled and claims to not find it. This switches all to use "internal" + "wasm" instead.

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as ready for review November 26, 2025 12:21
@quexten quexten requested a review from a team as a code owner November 26, 2025 12:21
@quexten quexten requested a review from dani-garcia November 26, 2025 12:21
@claude
Copy link

claude bot commented Nov 26, 2025

Claude finished @quexten's task —— View job


Code Review Complete

Summary of Changes Since Last Review

The PR has been updated following dani-garcia's feedback. The second commit (7515282) correctly changed the rust-analyzer.cargo.features setting from an array format to a plain string "all", which is the proper syntax for enabling all features in rust-analyzer.

Commit progression:

  1. First commit (2ccbed8): Changed from ["all"] to ["wasm", "internal"]
  2. Second commit (7515282): Changed to "all" as a plain string (per dani-garcia's suggestion)

Finding 1: PR Title and Description Need Improvement

💭 The PR objective states "Vscode is not happy with 'all' being enabled and claims to not find it. This switches all to use 'internal' + 'wasm' instead." However, this description is now outdated—the final implementation uses "all" as a plain string, not ["internal", "wasm"].

Suggested improvements

Title: No change needed - still accurate.

Objective section:

## 📔 Objective

VSCode's rust-analyzer was not recognizing the `"all"` feature when specified as an array element `["all"]`. The correct syntax requires `"all"` to be specified as a plain string value. This change fixes the configuration to use the proper format: `"rust-analyzer.cargo.features": "all"`.

Critical Issues Found

None - the code change is correct and follows rust-analyzer's expected configuration format.


Good Practices Observed

  • ✅ Responsive to reviewer feedback (dani-garcia's suggestion was implemented)
  • ✅ All CI checks passing (no breaking changes, security scan clean, coverage maintained)

Action Items

  1. Update the PR description's "Objective" section to reflect the actual final implementation (using "all" as a string rather than an array of specific features)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Logo
Checkmarx One – Scan Summary & Details1ec0e2b2-2b6d-41e0-be96-53c8b04d4bb7

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: km/fix-vscode (7515282)
Completed: 2025-11-26 12:49:00 UTC
Total Time: 217s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.46%. Comparing base (efed963) to head (7515282).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files         302      302           
  Lines       32331    32331           
=======================================
  Hits        25691    25691           
  Misses       6640     6640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Daniel García <dani-garcia@users.noreply.github.com>
@quexten quexten requested a review from dani-garcia November 26, 2025 12:36
@quexten quexten enabled auto-merge (squash) November 26, 2025 12:37
@quexten quexten merged commit 4b0d128 into main Nov 26, 2025
64 checks passed
@quexten quexten deleted the km/fix-vscode branch November 26, 2025 13:07
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants