Couple typos and possible future work #47

Merged
merged 2 commits into from Feb 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

mrdomino commented Feb 8, 2012

Fixed a couple typos, one of which (the type annotation) is code if you're using Closure.

I'm kinda interested in doing some more extensive cleanup (class names, layout, provides/requires for Closure package management)... would that be appreciated? I'm also thinking of sticking a Galois Field library here -- a more general version of https://github.com/mrdomino/lockbox/blob/master/gf28.js. Opinions?

@bitwiseshiftleft bitwiseshiftleft added a commit that referenced this pull request Feb 11, 2012

@bitwiseshiftleft bitwiseshiftleft Merge pull request #47 from mrdomino/master
Couple typos and possible future work
2f71b23

@bitwiseshiftleft bitwiseshiftleft merged commit 2f71b23 into bitwiseshiftleft:master Feb 11, 2012

Owner

bitwiseshiftleft commented Feb 11, 2012

Thanks for the patch. I'd be interested in cleanup. I'm not sure about a GF library. SJCL is supposed to be a simple, lean crypto library for an environment generally lacking in such things, rather than Crypto++/JS. Is there a particular use case for a GF library? And would you be focusing on GF(2^n), GF(3^n), or GF(p^small)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment