New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H264 and AAC broken? #216

Closed
dryeo opened this Issue May 28, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@dryeo
Contributor

dryeo commented May 28, 2017

http://html5test.com/ reports that our browser (Firefox 45.5.0 and SM 2.42) no longer support H264 and AAC. These worked with the 38ESR branch as long as the FFmpeg libs were on the LIBPATH. Unluckily I don't have the bandwidth to do much more testing

@dmik

This comment has been minimized.

Show comment
Hide comment
@dmik

dmik Jun 1, 2017

Contributor

It's broken indeed, looks like they changed the code that loads FFmpeg DLLs, a hundredth time. Need to check this.

Contributor

dmik commented Jun 1, 2017

It's broken indeed, looks like they changed the code that loads FFmpeg DLLs, a hundredth time. Need to check this.

@dmik dmik modified the milestones: Firefox Beta 9, Firefox GA Jun 1, 2017

@dmik

This comment has been minimized.

Show comment
Hide comment
@dmik

dmik Jun 1, 2017

Contributor

The new code attempts to load libEGL.so, this is clearly wrong but I remember I did something related to that when merging ESR 45 changes in. Needs to be checked.

Also I see now that the old code loading FFmpeg DLLs on the fly was moved from dom/media/fmp4/ffmpeg to dom/media/platforms/ffmpeg. Since our OS/2 patches were never there, they got lost. Need to restore it.

Contributor

dmik commented Jun 1, 2017

The new code attempts to load libEGL.so, this is clearly wrong but I remember I did something related to that when merging ESR 45 changes in. Needs to be checked.

Also I see now that the old code loading FFmpeg DLLs on the fly was moved from dom/media/fmp4/ffmpeg to dom/media/platforms/ffmpeg. Since our OS/2 patches were never there, they got lost. Need to restore it.

@dmik dmik self-assigned this Jun 1, 2017

@dmik dmik closed this in 20638b2 Jun 1, 2017

@dmik

This comment has been minimized.

Show comment
Hide comment
@dmik

dmik Jun 1, 2017

Contributor

Loading libEGL is disabled in 196b49c as it makes no sense ATM (there is no EGL port for OS/2 yet).

Loading FFmpeg is restored (see the above commit). Note that together with H264/AAC this also brought MP3 support according to html5test.com. Though I can't test it in real life since I have a problem with UNIAUD on my new OS/2 machine (it loads but no sound).

Contributor

dmik commented Jun 1, 2017

Loading libEGL is disabled in 196b49c as it makes no sense ATM (there is no EGL port for OS/2 yet).

Loading FFmpeg is restored (see the above commit). Note that together with H264/AAC this also brought MP3 support according to html5test.com. Though I can't test it in real life since I have a problem with UNIAUD on my new OS/2 machine (it loads but no sound).

@dryeo

This comment has been minimized.

Show comment
Hide comment
@dryeo

dryeo Jun 2, 2017

Contributor
Contributor

dryeo commented Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment