New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Not Add Duplicate Tilesets (or atleast warn and ask) #1227

Closed
reapazor opened this Issue Mar 19, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@reapazor

reapazor commented Mar 19, 2016

When adding images to a tileset, if the file is identical to an already existing item it should warn per item (add anyway, ignore, cancel)

There may be use cases for duplicates of the same tiles, however at times when you are dumping out parsed tilesets and adding in large number of images, having duplicates be created is frustrated.

@lazybotter

This comment has been minimized.

Show comment
Hide comment
@lazybotter

lazybotter Mar 19, 2016

Good shout! There should be a warning to overwrite the file.

lazybotter commented Mar 19, 2016

Good shout! There should be a warning to overwrite the file.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 19, 2016

Owner

@lazybotter As far as I understand this isn't about overwriting anything (Tiled should already warn about overwriting in all relevant cases, so please let me know if it isn't somewhere).

This issue is rather about Image Collection tilesets, where it does rarely make sense to add the same image twice to the collection. Since this is almost never what you want, it does indeed make sense to check against this case. I wonder if we can't just silently ignore this, even.

Owner

bjorn commented Mar 19, 2016

@lazybotter As far as I understand this isn't about overwriting anything (Tiled should already warn about overwriting in all relevant cases, so please let me know if it isn't somewhere).

This issue is rather about Image Collection tilesets, where it does rarely make sense to add the same image twice to the collection. Since this is almost never what you want, it does indeed make sense to check against this case. I wonder if we can't just silently ignore this, even.

@reapazor

This comment has been minimized.

Show comment
Hide comment
@reapazor

reapazor Mar 19, 2016

:) Indeed i get no error/warning when adding image.png to an existing collection with image.png in it already.

reapazor commented Mar 19, 2016

:) Indeed i get no error/warning when adding image.png to an existing collection with image.png in it already.

@bjorn bjorn added the usability label Oct 25, 2016

@bjorn bjorn closed this in #1461 Mar 8, 2017

bjorn added a commit that referenced this issue Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment