New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset properties crash in 0.16.0 #1268

Closed
enricllagostera opened this Issue May 6, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@enricllagostera

enricllagostera commented May 6, 2016

Hello everybody,

I just downloaded the 0.16.0 windows 32-bit version, I'm on Windows 10 64-bit. I need to change the tileset image filename, so that was the feature I was most interested in. I tried to open the Tileset Properties and every time it crashes Tiled. I've included a gif of what is going on.

I don't have much more new info, but if you instruct me, I can try to get it.

Cheers.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 6, 2016

Owner

Arg, I am just releasing Tiled 0.16.1 and I don't think it fixes anything like this. Will need to see if I can reproduce it.

Owner

bjorn commented May 6, 2016

Arg, I am just releasing Tiled 0.16.1 and I don't think it fixes anything like this. Will need to see if I can reproduce it.

@bjorn bjorn added bug windows labels May 6, 2016

@enricllagostera

This comment has been minimized.

Show comment
Hide comment
@enricllagostera

enricllagostera May 6, 2016

Hmm, is there anything I can do to help figuring this bug out? Any relevant specs I can send to you?

enricllagostera commented May 6, 2016

Hmm, is there anything I can do to help figuring this bug out? Any relevant specs I can send to you?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 6, 2016

Owner

Unless you are able to narrow down when this is happening, I'm afraid the main thing you could do to help me is quite a bit of work. You'd have to compile Tiled from source and run it in a debugger, to see where it is crashing exactly.

I've tried arranging my dock widgets like you have it and testing with 32-bit Tiled on 64-bit Windows, but I'm unable to reproduce this crash.

I actually wonder if it is a variation on issue #1153, because that one was related to loading of native file icons in Qt, and the "Filename" property does also try to display the native file icon.

Owner

bjorn commented May 6, 2016

Unless you are able to narrow down when this is happening, I'm afraid the main thing you could do to help me is quite a bit of work. You'd have to compile Tiled from source and run it in a debugger, to see where it is crashing exactly.

I've tried arranging my dock widgets like you have it and testing with 32-bit Tiled on 64-bit Windows, but I'm unable to reproduce this crash.

I actually wonder if it is a variation on issue #1153, because that one was related to loading of native file icons in Qt, and the "Filename" property does also try to display the native file icon.

@enricllagostera

This comment has been minimized.

Show comment
Hide comment
@enricllagostera

enricllagostera May 6, 2016

Ok, I'll try to do the compiling and debugging later in the weekend.
Some other things that might help (?):

  • The tmx file was created in another version of Tiled (0.10.2).
  • I had moved the tileset file to another location before and then had to copy it again to the original location to be able to re-open this .tmx file.
  • I tried with OpenGL both enabled and disabled and behaviour stayed the same.

Is it possible to somehow disable this Filename icon only? I can run it here and test.

enricllagostera commented May 6, 2016

Ok, I'll try to do the compiling and debugging later in the weekend.
Some other things that might help (?):

  • The tmx file was created in another version of Tiled (0.10.2).
  • I had moved the tileset file to another location before and then had to copy it again to the original location to be able to re-open this .tmx file.
  • I tried with OpenGL both enabled and disabled and behaviour stayed the same.

Is it possible to somehow disable this Filename icon only? I can run it here and test.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 6, 2016

Owner

Is it possible to somehow disable this Filename icon only? I can run it here and test.

If you compile Tiled yourself, you can disable the file name icon by changing line 167 (return mIconProvider.icon(QFileInfo(filePath))) in variantpropertymanager.cpp to just return QIcon().

Owner

bjorn commented May 6, 2016

Is it possible to somehow disable this Filename icon only? I can run it here and test.

If you compile Tiled yourself, you can disable the file name icon by changing line 167 (return mIconProvider.icon(QFileInfo(filePath))) in variantpropertymanager.cpp to just return QIcon().

@enricllagostera

This comment has been minimized.

Show comment
Hide comment
@enricllagostera

enricllagostera May 6, 2016

Ok, I'll try to do it then. I'll let you know the results.

enricllagostera commented May 6, 2016

Ok, I'll try to do it then. I'll let you know the results.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 6, 2016

Owner

Alright. If it's related to the icon, it will get resolved once Qt 5.6.1 is released and I manage to make the releases work against that.

Owner

bjorn commented May 6, 2016

Alright. If it's related to the icon, it will get resolved once Qt 5.6.1 is released and I manage to make the releases work against that.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jun 13, 2016

Owner

This issue is fixed in the current snapshot builds (starting from tiled-0.16.1006), which are compiled against Qt 5.6.1. I'll probably make a Tiled 0.16.2 release with these fixes sometime soon.

@enricllagostera Maybe you could try this snapshot build to verify that it really resolved your crash.

Owner

bjorn commented Jun 13, 2016

This issue is fixed in the current snapshot builds (starting from tiled-0.16.1006), which are compiled against Qt 5.6.1. I'll probably make a Tiled 0.16.2 release with these fixes sometime soon.

@enricllagostera Maybe you could try this snapshot build to verify that it really resolved your crash.

@bjorn bjorn closed this Jun 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment