New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed in map toggle for new tilesets should be persistent #1664

Closed
bjorn opened this Issue Jul 26, 2017 · 2 comments

Comments

2 participants
@bjorn
Owner

bjorn commented Jul 26, 2017

When somebody turns on "Embed in map", it can be expected that they want to embed the next tileset as well. So the value of the checkbox should really be persistent, like most other values in the New Tileset dialog.

[21:48:30] <Guest17760> hey
[21:48:35] <Guest17760> i need help with Tiled
[21:49:49] <Guest17760> whenever i upload something to the tile set i have to "save as" every single file
[21:50:25] <Guest17760> there's an option "embeded" i have to tick it with every file to upload without "save as"
[21:50:34] <Guest17760> how to make it default ticked
[21:50:49] <Guest17760> i saw a video he did not have to save as he just spammed ok

(the button used to just be "OK" because before Tiled 1.0, tilesets were always embedded in the map)

@bjorn bjorn added the usability label Jul 26, 2017

@ibrahimsharaf

This comment has been minimized.

Show comment
Hide comment
@ibrahimsharaf

ibrahimsharaf Jul 27, 2017

Hi @bjorn, how can I start working on this issue?

ibrahimsharaf commented Jul 27, 2017

Hi @bjorn, how can I start working on this issue?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 28, 2017

Owner

@ibrahimsharaf Thanks for your interest in resolving this issue! You can find some general guidance on how to get started with Tiled development at https://github.com/bjorn/tiled/wiki/Contributing-to-Tiled.

The code changes required here will be in newtilesetdialog.cpp. Feel free to ask any questions.

Owner

bjorn commented Jul 28, 2017

@ibrahimsharaf Thanks for your interest in resolving this issue! You can find some general guidance on how to get started with Tiled development at https://github.com/bjorn/tiled/wiki/Contributing-to-Tiled.

The code changes required here will be in newtilesetdialog.cpp. Feel free to ask any questions.

@bjorn bjorn added this to Up Next in Roadmap Sep 6, 2017

@bjorn bjorn moved this from Up Next to Recently Completed in Roadmap Sep 12, 2017

@bjorn bjorn closed this in e4c2fe8 Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment