New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rightclick on tab to close tabs #1720

Closed
issy123 opened this Issue Sep 5, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@issy123

issy123 commented Sep 5, 2017

  • close other tabs
  • close all tabs
  • close all left to this tab
  • close all right to this tab

@bjorn bjorn added the feature label Sep 5, 2017

@bjorn bjorn changed the title from [feature] rightclick on tab to close tabs to Rightclick on tab to close tabs Sep 5, 2017

@bjorn bjorn added the usability label Sep 5, 2017

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Sep 5, 2017

Owner

At least "Close All Tabs" is already in "File -> Close All (Ctrl+Shift+W)", so I see no point in adding that one.

I see both Chromium and Firefox only have "Close Tabs to the Right" and not a "to the Left" version. If even such tab-heavy applications don't have it it makes me think there isn't enough demand to worry about that one in Tiled.

So I guess adding these should be enough:

  • Close Other Tabs
  • Close Tabs to the Right

Or have you personally been missing the other ones?

I also think we should add middle-click for closing a tab.

Owner

bjorn commented Sep 5, 2017

At least "Close All Tabs" is already in "File -> Close All (Ctrl+Shift+W)", so I see no point in adding that one.

I see both Chromium and Firefox only have "Close Tabs to the Right" and not a "to the Left" version. If even such tab-heavy applications don't have it it makes me think there isn't enough demand to worry about that one in Tiled.

So I guess adding these should be enough:

  • Close Other Tabs
  • Close Tabs to the Right

Or have you personally been missing the other ones?

I also think we should add middle-click for closing a tab.

@EJlol

This comment has been minimized.

Show comment
Hide comment
@EJlol

EJlol Sep 5, 2017

Some programs with a tabbar also support opening a new tab. For instance in Firefox you can use the middle-click to open a new tab, and in notepad++ you can double click to open a new tab. Chrome and Edge only has a button in the tabbar, and Paint.net doesn't support opening a new tab in the tabbar at all.

I'm not sure how usefull or confusing (since there are maps and tilesets in the tabbar) a feature like this would be for Tiled, but you might also look into that.

EJlol commented Sep 5, 2017

Some programs with a tabbar also support opening a new tab. For instance in Firefox you can use the middle-click to open a new tab, and in notepad++ you can double click to open a new tab. Chrome and Edge only has a button in the tabbar, and Paint.net doesn't support opening a new tab in the tabbar at all.

I'm not sure how usefull or confusing (since there are maps and tilesets in the tabbar) a feature like this would be for Tiled, but you might also look into that.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Sep 5, 2017

Owner

I'm not sure how useful or confusing (since there are maps and tilesets in the tabbar) a feature like this would be for Tiled, but you might also look into that.

Indeed, such an action would either have to pop up a dialog for creating a new map or tileset, or the tab would need to show some kind of "start page" similar to what Tiled currently shows when nothing is open. But I think such functionality wouldn't be very useful.

Owner

bjorn commented Sep 5, 2017

I'm not sure how useful or confusing (since there are maps and tilesets in the tabbar) a feature like this would be for Tiled, but you might also look into that.

Indeed, such an action would either have to pop up a dialog for creating a new map or tileset, or the tab would need to show some kind of "start page" similar to what Tiled currently shows when nothing is open. But I think such functionality wouldn't be very useful.

@bjorn bjorn added the bounty label Sep 26, 2017

dorkster added a commit to dorkster/tiled that referenced this issue Sep 26, 2017

Improve tab closing functionality (bjorn#1720)
This commit adds "Close", "Close Other Tabs", and "Close Tabs To The
Right" to the document tab context menu. It also adds the ability to
close tabs with middle-click.

dorkster added a commit to dorkster/tiled that referenced this issue Oct 7, 2017

Improve tab closing functionality (bjorn#1720)
This commit adds "Close", "Close Other Tabs", and "Close Tabs To The
Right" to the document tab context menu. It also adds the ability to
close tabs with middle-click.

@bjorn bjorn closed this in 6cca361 Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment