New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fixing wrong paths to tilesets in templates #1732

Closed
thabetx opened this Issue Sep 6, 2017 · 6 comments

Comments

2 participants
@thabetx
Contributor

thabetx commented Sep 6, 2017

Currently Tiled can fix a wrong path of a template referenced by a map. But doesn't offer fixing tileset references inside of template files.

Since template files aren't opened as top-level documents and any changes to them are saved immediately, they will need some special handling.

@bjorn bjorn added this to Tiled 1.1 in Roadmap Sep 6, 2017

@bjorn bjorn changed the title from Allow fixing wrong paths of template groups to Allow fixing wrong paths to tilesets in templates Nov 21, 2017

@bjorn

This comment has been minimized.

Owner

bjorn commented Nov 21, 2017

I've updated the title and description of this task to account for change ce60ac9, which removed the template groups.

@thabetx

This comment has been minimized.

Contributor

thabetx commented Nov 30, 2017

The scenario for this is opening a map which has an instance of a template that has a broken link to a tileset. The main thing here is that there is no thing wrong with the MapDocument itself, and the map doesn't own the template and has no means of changing it.

This is exactly like fixing the image of the tileset, we open the tileset and fix it there.

So, what about offering to fix the template by loading it in the template viewer, there would be an option there to fix the tileset, I'm currently thinking of a context menu entry called "Replace Broken Tileset", and we should also be able to right click and replace the tile like #1525 (Replace object tile) .

I'm not sure if this is the best solution, and I'm open for suggestions.

@bjorn

This comment has been minimized.

Owner

bjorn commented Nov 30, 2017

@thabetx I like your suggestion, but I think it would need to be rather visible rather than hidden in a context menu, so for example a bar saying "Tileset not found" with a "Locate Tileset" button at the top of the template view.

Hmm, do we handle already images failing to load in a tileset referenced by a template? I think not...

In general I'm wondering if there isn't an easier way of dealing with broken references...

@thabetx

This comment has been minimized.

Contributor

thabetx commented Dec 1, 2017

I'm thinking of adding a "Fix Tileset" button beside the tools in the templates dock, it only appears when there is a problem with the tileset, and it should work like the fix button in the broken links widget (promoting to change the path if it's the problem or open the tileset if the image is the problem).

@bjorn

This comment has been minimized.

Owner

bjorn commented Dec 4, 2017

@thabetx Yeah, that could work fine.

@bjorn

This comment has been minimized.

Owner

bjorn commented Dec 18, 2017

Closed by #1831.

@bjorn bjorn closed this Dec 18, 2017

@bjorn bjorn moved this from Tiled 1.1 to Recently Completed in Roadmap Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment