New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to user regarding current active tool in the bottom StatusBar. #1855

Open
keshav2010 opened this Issue Jan 12, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@keshav2010
Contributor

keshav2010 commented Jan 12, 2018

While working with Tiled, I noticed that the bottom most info-bar (which often displays information such as mouse coordinates along with the grid's coordinates we are currently pointing to) can be utilized to display information related to tool which is at that instant of time being used by user, specially for tools such as
"Insert Polygon" where i believe it might be a good step to display information such as which key to press to confirm the polygon constructed so far or key which can be pressed to remove it.

capture

@bjorn

This comment has been minimized.

Owner

bjorn commented Jan 13, 2018

Yeah, the status bar could definitely be more helpful. I think Inkscape sets a good example for this.

@keshav2010 keshav2010 closed this Jan 13, 2018

@keshav2010 keshav2010 reopened this Jan 13, 2018

@keshav2010

This comment has been minimized.

Contributor

keshav2010 commented Jan 13, 2018

yeah, i will be looking over to implement this feature, as of now, im wondering if its a good choice to implement this as a tiny system in itself, that will be notified about current active tool and fetch information related to it, translate it into user's choice of language (English, etc) and display it on status bar ?
i will be however having a look over the code, since my current understanding regarding Tiled's way of interacting with this status bar is vague, to see how information is currently being passed on to the status bar (regarding mouse position and grid location) , although its numerical data so no translation would be required, this might eventually help me figure out a proper implementation, if there is any suggestion on this issue that would be very helpful.

@keshav2010 keshav2010 changed the title from Suggestions to user regarding current active tool in the bottom infobar. to Suggestions to user regarding current active tool in the bottom StatusBar. Jan 13, 2018

@satu0king

This comment has been minimized.

Contributor

satu0king commented Jan 14, 2018

I would love to work on this feature. @bjorn any tips on how to implement this?
@keshav2010 did you start working on it yet?

@keshav2010

This comment has been minimized.

Contributor

keshav2010 commented Jan 14, 2018

@satu0king Nope I'm still figuring out a proper way to implement this, since this feature should be implemented as such so as to make sure if any new tool is added into Tiled in future, it should be fairly easy to link its information.

I'm still not sure which way to follow, a separate class that maps information related to a tool by treating its name as Key and receives the current active tool and broadcast its information on status Bar

or we can go the other way around and just alter the current existing Abstract-tool class.
Would be glad to have your participation in this too😃

@satu0king

This comment has been minimized.

Contributor

satu0king commented Jan 14, 2018

Cool loop me in when u start working on it. I think having an XML file which has entries for each tool item should work fine. When the user clicks on the tool, the status bar can be updated.

@bjorn

This comment has been minimized.

Owner

bjorn commented Jan 14, 2018

It could be done either as part of or similar to AbstractTool::statusInfo.

@keshav2010

This comment has been minimized.

Contributor

keshav2010 commented Jan 15, 2018

Alright, i will begin implementing it for tools that can be selected while working on an Object Layer (such as insert-polygon, polyline, etc).
Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment