New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quit shortcut is not implemented for windows (easy fix) #1998

Closed
Yoonwoo opened this Issue Aug 31, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Yoonwoo

Yoonwoo commented Aug 31, 2018

Currently Tiled uses QKeySequence::Quit when using setShortcut for the quit action. This constant has no standard keyboard shortcut on windows. See this table in docs.

All platforms use ctrl+Q, so the code can be something like

mUi->actionQuit->setShortcut(QKeySequence(tr("Ctrl+Q")));

The code is this at the moment:
mUi->actionQuit->setShortcuts(QKeySequence::Quit);

@bjorn

This comment has been minimized.

Owner

bjorn commented Aug 31, 2018

What other apps close with Ctrl+Q on Windows? My guess would be only a few that originate from the Linux world, but I may be wrong of course. On Windows the standard close shortcut is Alt+F4, which works without explicitly registering it.

That said, unless Ctrl+Q is commonly used for something else on Windows, I wouldn't really have a problem with making it an alternative shortcut for quitting.

@Yoonwoo

This comment has been minimized.

Yoonwoo commented Sep 1, 2018

The only example I have is VLC. I just thought since Tiled will close with CTRL+Q on other platforms it should on Windows too. But its really up to your preference, it doesn't matter much.

@bjorn bjorn closed this in bfc901a Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment