Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze when locating missing tilesheet for tbin #2068

Closed
Pathoschild opened this Issue Feb 4, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@Pathoschild
Copy link

Pathoschild commented Feb 4, 2019

Tiled freezes when you locate a missing tilesheet for Stardew Valley .tbin maps.

Repro steps

  1. Download this map + tilesheets: repro.zip.
  2. Open the FarmCave.tbin file in Tiled. It will report a missing mine file:

  3. Double-click a tileset to open it:

  4. Double-click a file to open the choose-file dialogue:

  5. Choose the mine.png file and click 'open'.
  6. Tiled freezes indefinitely, and task manager shows it quickly consuming all available RAM (25+ GB).

Environment

Reproduced on Windows 10 (Home 1809 build 17763.253) and multiple 64-bit Tiled versions from snapshot 2018.01.01 to 1.2.2.

@Dawilly

This comment has been minimized.

Copy link

Dawilly commented Feb 4, 2019

Replicating the steps provided causes Tiled for freeze indefinitely for me as well. However, repeating the same procedure with a .tmx map in place of a .tbin map does not trigger the bug. So it appears to be .tbin exclusive.

@bjorn bjorn added the bug label Feb 4, 2019

@bjorn

This comment has been minimized.

Copy link
Owner

bjorn commented Feb 4, 2019

This only affected maps loaded through the tBIN plugin due to the way it was adding missing tiles to still be able to load the tile properties. Will be fixed in an eventual Tiled 1.2.3 or the next development snapshot (planned for tomorrow).

Thanks for the report!

@bjorn bjorn closed this in 1972975 Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.