Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiledquick packaging? #2673

Closed
AMDmi3 opened this issue Nov 17, 2019 · 4 comments
Closed

tiledquick packaging? #2673

AMDmi3 opened this issue Nov 17, 2019 · 4 comments

Comments

@AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Nov 17, 2019

Hi, I'm working on an update of FreeBSD port of tiled to 1.3.0 and it turns out that it now installs tiledquick binary, which is installed into /opt for some reason, and also fails to run:

% tiledquick
QQmlApplicationEngine failed to load component
qrc:/main.qml:6 module "Qt.labs.platform" is not installed
qrc:/main.qml:2 module "QtQuick.Controls" is not installed
qrc:/main.qml:6 module "Qt.labs.platform" is not installed
qrc:/main.qml:2 module "QtQuick.Controls" is not installed

Is it needed? Where should it be installed? Should it be fixed somehow?

@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Nov 17, 2019

Hmm, I should probably look into disabling the installing and possibly also the compiling of this tool by default. It is not currently worth packaging properly because it's only a map viewer with very limited functionality.

That it installs to /opt seems to be because of the rules in src/tiledquick/deployment.pri, which was mostly intended to help with Android deployment. Since I use Qbs I never noticed this oddity in the qmake project. I would recommend you to switch to using Qbs for FreeBSD packaging as well.

In any case, I'll have a look at adjusting the project files. Thanks for raising this issue!

@AMDmi3

This comment has been minimized.

Copy link
Contributor Author

@AMDmi3 AMDmi3 commented Nov 18, 2019

I should probably look into disabling the installing and possibly also the compiling of this tool by default

Got it, so I guess I'll disable it in src/src.pro for 1.3.0.

I would recommend you to switch to using Qbs for FreeBSD packaging as well

Sorry, but I'd strongly prefer to stick with standard and supported (both upstream and by our existing build infrastructure) tools.

@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Nov 18, 2019

Got it, so I guess I'll disable it in src/src.pro for 1.3.0.

Yes, that's a good idea, along with the tiledquickplugin sub-project.

Sorry, but I'd strongly prefer to stick with standard and supported (both upstream and by our existing build infrastructure) tools.

I totally understand, but keeping qmake working comes with a maintenance overhead for myself and a consistent stumbling block for any contributors. The only reason the qmake files are still there is because I use them to update the translation files (see #1484).

Maybe on the bright side for packaging, Qt has chosen to deprecate Qbs and to push for cmake instead. For now I love Qbs and am pretty sad about this decision, but it could mean that Tiled will build with cmake in the future.

@AMDmi3

This comment has been minimized.

Copy link
Contributor Author

@AMDmi3 AMDmi3 commented Nov 18, 2019

I totally understand, but keeping qmake working comes with a maintenance overhead for myself and a consistent stumbling block for any contributors.

Totally understandable as well, but Qbs is likely going to be a similar block.

but it could mean that Tiled will build with cmake in the future

That would be great!

@bjorn bjorn closed this in 7be422a Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.