Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior for stamp and eraser #2719

Closed
Phlosioneer opened this issue Dec 29, 2019 · 1 comment
Closed

Inconsistent behavior for stamp and eraser #2719

Phlosioneer opened this issue Dec 29, 2019 · 1 comment
Labels
bug
Projects

Comments

@Phlosioneer
Copy link
Contributor

@Phlosioneer Phlosioneer commented Dec 29, 2019

When opening a new map, the stamp tool will work immediately. But the erase tool will not work until you've selected a layer.

I think this behavior issue only applies to maps with exactly one layer (e.g. when creating a new map).

It's caused me confusion in the past, and someone else recently: https://discourse.mapeditor.org/t/very-newbie-eraser-tip/4271

@Phlosioneer Phlosioneer changed the title Inconsistent behavior for stamp and erase Inconsistent behavior for stamp and eraser Dec 29, 2019
@bjorn bjorn added the bug label Dec 29, 2019
@bjorn bjorn added this to Tiled 1.3 (bugfixes) in Roadmap Dec 29, 2019
@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Dec 29, 2019

Problem is that mSelectedLayers is left empty by MapDocument constructor instead of being set to a list with mCurrentLayer if that value is not nullptr. The eraser applies to the selected layers.

The inconsistency happens because the stamp tool has some special logic applying to the "current layer", but really the "current layer" should always be a selected layer.

@bjorn bjorn closed this in 5534327 Jan 22, 2020
Roadmap automation moved this from Tiled 1.3 (bugfixes) to Recently Completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Recently Completed
2 participants
You can’t perform that action at this time.