Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting custom properties on tileset through scripting crashes Tiled #2747

Closed
EJlol opened this issue Jan 31, 2020 · 2 comments
Closed

Setting custom properties on tileset through scripting crashes Tiled #2747

EJlol opened this issue Jan 31, 2020 · 2 comments
Labels
Projects

Comments

@EJlol
Copy link

@EJlol EJlol commented Jan 31, 2020

Running the following js script crashes Tiled:
new Tileset().setProperty('key', 'value');

Tiled crashes without any error message.

@bjorn bjorn added bug urgent labels Jan 31, 2020
@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Jan 31, 2020

Thanks for the report @EJlol, that's pretty bad!

@bjorn bjorn added this to Tiled 1.3 (bugfixes) in Roadmap Jan 31, 2020
@bjorn bjorn closed this in c4c91e3 Feb 12, 2020
Roadmap automation moved this from Tiled 1.3 (bugfixes) to Recently Completed Feb 12, 2020
@bjorn

This comment has been minimized.

Copy link
Owner

@bjorn bjorn commented Feb 12, 2020

It was trying to use a nullptr as undo stack, because the condition to check for undo stack availability was outdated... Hopefully it all works fine now.

The fix is included in today's development snapshot and will be in Tiled 1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Recently Completed
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.