Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMX Format doc: explicitly say which attributes and children are required #696

Closed
bitjammer opened this issue Jul 7, 2014 · 0 comments · Fixed by #2702
Closed

TMX Format doc: explicitly say which attributes and children are required #696

bitjammer opened this issue Jul 7, 2014 · 0 comments · Fixed by #2702
Labels
documentation Issue related to the Tiled Manual.

Comments

@bitjammer
Copy link

https://github.com/bjorn/tiled/wiki/TMX-Map-Format says that the DTD file is "not up-to-date", yet the documentation isn't clear on which elements/attributes are required.

"Can contain" isn't indicative of optionality but children. For example, map.backgroundcolor is optional. That's fine, but indicate that they are children*. The documentation should explicitly say which attributes and child elements are optional for each element.

@bjorn bjorn added the documentation Issue related to the Tiled Manual. label Aug 17, 2015
Phlosioneer added a commit to Phlosioneer/tiled that referenced this issue Dec 18, 2019
All "can contain" entries have been split into "can contain at most one"
and "can contain any number". Additionally, there is now a note to
implementors at the top of the specification listing how to handle parsing
errors. (More of a reminder on how to handle XML errors in general, since
TMX is a form of XML.)

Closes mapeditor#696, mapeditor#1754
bjorn pushed a commit that referenced this issue Dec 18, 2019
All "can contain" entries have been split into "can contain at most one"
and "can contain any number". Additionally, there is now a note to
implementors at the top of the specification listing how to handle parsing
errors. (More of a reminder on how to handle XML errors in general, since
TMX is a form of XML.)

Closes #696
Closes #1754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to the Tiled Manual.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants