New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added export to Defold .tilemap files #1316

Closed
wants to merge 19 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@yahuaru
Contributor

yahuaru commented Jul 17, 2016

No description provided.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 17, 2016

Owner

Hmm, something went really wrong here. Maybe I should try to make a single commit? I'm not sure how to walk you through doing the right git commands.

Owner

bjorn commented Jul 17, 2016

Hmm, something went really wrong here. Maybe I should try to make a single commit? I'm not sure how to walk you through doing the right git commands.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 17, 2016

Owner

I've pushed a clean commit to my wip/defold branch (90233f3) and tried to test this plugin.

Unfortunately, I could not get Defold to work. Once I try to open an example project in the editor, it wants me to create a branch, but whatever I type I always get the message "Unable to create branch". Did you ever run into or hear about this problem? I'm on 64-bit Linux.

Owner

bjorn commented Jul 17, 2016

I've pushed a clean commit to my wip/defold branch (90233f3) and tried to test this plugin.

Unfortunately, I could not get Defold to work. Once I try to open an example project in the editor, it wants me to create a branch, but whatever I type I always get the message "Unable to create branch". Did you ever run into or hear about this problem? I'm on 64-bit Linux.

@bjorn bjorn self-assigned this Jul 17, 2016

@bjorn bjorn added the feature label Jul 17, 2016

@yahuaru

This comment has been minimized.

Show comment
Hide comment
@yahuaru

yahuaru Jul 17, 2016

Contributor

I'm on 64-bit XUbuntu. Had that problem sometime. Not quiet remember, I
think it auto-resolved just wait some time. I can check your map if you
send me it.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 13:27 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

I've pushed a clean commit to my wip/defold branch (90233f3
90233f3)
and tried to test this plugin.

Unfortunately, I could not get Defold to work. Once I try to open an
example project in the editor, it wants me to create a branch, but whatever
I type I always get the message "Unable to create branch". Did you ever run
into or hear about this problem? I'm on 64-bit Linux.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB3QoYqr2c-hAxop-8XSEUkLerKowc_Vks5qWgOcgaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

Contributor

yahuaru commented Jul 17, 2016

I'm on 64-bit XUbuntu. Had that problem sometime. Not quiet remember, I
think it auto-resolved just wait some time. I can check your map if you
send me it.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 13:27 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

I've pushed a clean commit to my wip/defold branch (90233f3
90233f3)
and tried to test this plugin.

Unfortunately, I could not get Defold to work. Once I try to open an
example project in the editor, it wants me to create a branch, but whatever
I type I always get the message "Unable to create branch". Did you ever run
into or hear about this problem? I'm on 64-bit Linux.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB3QoYqr2c-hAxop-8XSEUkLerKowc_Vks5qWgOcgaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 17, 2016

Owner

Ok I've tried it on Windows now and there I didn't have the branch problem.

A few questions about this export:

  • Would there be some solution for the empty tileset_set property? As it is, each time after the export, you need to re-set the "Tile Source" in Defold. I imagine, that maybe an export for the tilesets to .tilesource could be added as well, since the properties are similar. And then Tiled may know which files to reference there when exporting the map.
  • What are the map_nodes and Objects tables for in the .tilemap.script file? Do I understand correctly, that these variables become global values in some Lua state?
  • The flipped tiles in the orthogonal-outside.tmx example in the Tiled repository did not appear to get flipped in Defold. Is this feature somehow only supported in their .tilemap format, but not yet by their renderer? (I also can't find tile flipping in the Defold editor)

Overall, it's a good start and after trying the tilemap editor in Defold for a bit I can imagine why you'd want to use Tiled instead. It's a pity the rest of the things don't map well to Defold's data structures like the .collection file with game objects with components.

I think Defold is a good example of where Tiled could go, to be a more useful generic level editor.

Owner

bjorn commented Jul 17, 2016

Ok I've tried it on Windows now and there I didn't have the branch problem.

A few questions about this export:

  • Would there be some solution for the empty tileset_set property? As it is, each time after the export, you need to re-set the "Tile Source" in Defold. I imagine, that maybe an export for the tilesets to .tilesource could be added as well, since the properties are similar. And then Tiled may know which files to reference there when exporting the map.
  • What are the map_nodes and Objects tables for in the .tilemap.script file? Do I understand correctly, that these variables become global values in some Lua state?
  • The flipped tiles in the orthogonal-outside.tmx example in the Tiled repository did not appear to get flipped in Defold. Is this feature somehow only supported in their .tilemap format, but not yet by their renderer? (I also can't find tile flipping in the Defold editor)

Overall, it's a good start and after trying the tilemap editor in Defold for a bit I can imagine why you'd want to use Tiled instead. It's a pity the rest of the things don't map well to Defold's data structures like the .collection file with game objects with components.

I think Defold is a good example of where Tiled could go, to be a more useful generic level editor.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 17, 2016

Owner

I've pushed this plugin to the master branch after some cleanups (c454a4c). Please do still try to answer my above questions.

Further improvements to the plugin are also welcome, just be sure to base them on the latest version.

Owner

bjorn commented Jul 17, 2016

I've pushed this plugin to the master branch after some cleanups (c454a4c). Please do still try to answer my above questions.

Further improvements to the plugin are also welcome, just be sure to base them on the latest version.

@bjorn bjorn closed this Jul 17, 2016

@yahuaru

This comment has been minimized.

Show comment
Hide comment
@yahuaru

yahuaru Jul 17, 2016

Contributor

Just remembered. You need run through Defold-linux.sh under sudo.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 17:46 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

Closed #1316 #1316.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB3QoRpMWpch-wmMFR_3stT7wnskFjb8ks5qWkAogaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

Contributor

yahuaru commented Jul 17, 2016

Just remembered. You need run through Defold-linux.sh under sudo.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 17:46 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

Closed #1316 #1316.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB3QoRpMWpch-wmMFR_3stT7wnskFjb8ks5qWkAogaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

@yahuaru

This comment has been minimized.

Show comment
Hide comment
@yahuaru

yahuaru Jul 17, 2016

Contributor

Actually plugin was maked just for myself and my project, so there lot
needed to fix for community. I actually made it month ago and thinked to
show you just now. Further I will fix all my questionable decisions for
community usability.

Would there be some solution for the empty tileset_set property? As it
is, each time after the export, you need to re-set the "Tile Source" in
Defold. I imagine, that maybe an export for the tilesets
to .tilesource could be added as well, since the properties are similar.
And then Tiled may know which files to reference there when exporting the
map.

It actuallly better decision, will add later.

What are the map_nodes and Objects tables for in
the .tilemap.script file? Do I understand correctly, that these variables
become global values in some Lua state?

It is representation for property/value objects and tiles. But i make it
only for spefic properties, repeat only for my project. So i really should
add export for all property/value.

The flipped tiles in the orthogonal-outside.tmx example in the Tiled
repository did not appear to get flipped in Defold. Is this feature somehow
only supported in their.tilemap format, but not yet by their renderer? (I
also can't find tile flipping in the Defold editor)

I actually don't clearly know how it works, so will experiment later with
it. Just to know what needed to be changed.

Thanks for your nice critique. I will show all results to you by progress.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 18:32 GMT+03:00 Никита Раздобреев exzo0mex@gmail.com:

Just remembered. You need run through Defold-linux.sh under sudo.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 17:46 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

Closed #1316 #1316.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB3QoRpMWpch-wmMFR_3stT7wnskFjb8ks5qWkAogaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

С уважением,
Раздобреев Никита

Contributor

yahuaru commented Jul 17, 2016

Actually plugin was maked just for myself and my project, so there lot
needed to fix for community. I actually made it month ago and thinked to
show you just now. Further I will fix all my questionable decisions for
community usability.

Would there be some solution for the empty tileset_set property? As it
is, each time after the export, you need to re-set the "Tile Source" in
Defold. I imagine, that maybe an export for the tilesets
to .tilesource could be added as well, since the properties are similar.
And then Tiled may know which files to reference there when exporting the
map.

It actuallly better decision, will add later.

What are the map_nodes and Objects tables for in
the .tilemap.script file? Do I understand correctly, that these variables
become global values in some Lua state?

It is representation for property/value objects and tiles. But i make it
only for spefic properties, repeat only for my project. So i really should
add export for all property/value.

The flipped tiles in the orthogonal-outside.tmx example in the Tiled
repository did not appear to get flipped in Defold. Is this feature somehow
only supported in their.tilemap format, but not yet by their renderer? (I
also can't find tile flipping in the Defold editor)

I actually don't clearly know how it works, so will experiment later with
it. Just to know what needed to be changed.

Thanks for your nice critique. I will show all results to you by progress.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 18:32 GMT+03:00 Никита Раздобреев exzo0mex@gmail.com:

Just remembered. You need run through Defold-linux.sh under sudo.

Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-17 17:46 GMT+03:00 Thorbjørn Lindeijer notifications@github.com:

Closed #1316 #1316.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB3QoRpMWpch-wmMFR_3stT7wnskFjb8ks5qWkAogaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

С уважением,
Раздобреев Никита

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 17, 2016

Owner

Alright, I understand it has some specific functionality for your project, but Defold seems to be pretty popular and it looked like Tiled can add a lot in terms of tile map editing. Hence I was eager to merge this plugin. However, indeed some changes to make it more generic would be good, so it's nice to hear you'd like to work on this.

Note that Tiled already has a generic Lua export. Maybe it would be better to rely on that for people who need more information from the Tiled map? Sure it will have some tile map stuff duplicated, but I don't think that's really a problem?

For adding a .tilesource export, note that there is still some work to be done before Tiled can support export-only tileset formats (currently it supports only read-write formats). So before you work on this you may want to wait until I've had a chance to get around to that (I need to do this for adding Lua tileset export, and I'll do it in the wip/tilesetdocument branch).

Owner

bjorn commented Jul 17, 2016

Alright, I understand it has some specific functionality for your project, but Defold seems to be pretty popular and it looked like Tiled can add a lot in terms of tile map editing. Hence I was eager to merge this plugin. However, indeed some changes to make it more generic would be good, so it's nice to hear you'd like to work on this.

Note that Tiled already has a generic Lua export. Maybe it would be better to rely on that for people who need more information from the Tiled map? Sure it will have some tile map stuff duplicated, but I don't think that's really a problem?

For adding a .tilesource export, note that there is still some work to be done before Tiled can support export-only tileset formats (currently it supports only read-write formats). So before you work on this you may want to wait until I've had a chance to get around to that (I need to do this for adding Lua tileset export, and I'll do it in the wip/tilesetdocument branch).

@yahuaru

This comment has been minimized.

Show comment
Hide comment
@yahuaru

yahuaru Jul 18, 2016

Contributor

Ok. Thanks for mention lua export, it totally changed my plans for work. I have some free time on this week, so I expecting make radical changes really soon

-----Исходное сообщение-----
От: "Thorbjørn Lindeijer" notifications@github.com
Отправлено: ‎17.‎07.‎2016 23:06
Кому: "bjorn/tiled" tiled@noreply.github.com
Копия: "kekdck" exzo0mex@gmail.com; "Author" author@noreply.github.com
Тема: Re: [bjorn/tiled] Added export to Defold .tilemap files (#1316)

Alright, I understand it has some specific functionality for your project, but Defold seems to be pretty popular and it looked like Tiled can add a lot in terms of tile map editing. Hence I was eager to merge this plugin. However, indeed some changes to make it more generic would be good, so it's nice to hear you'd like to work on this.
Note that Tiled already has a generic Lua export. Maybe it would be better to rely on that for people who need more information from the Tiled map? Sure it will have some tile map stuff duplicated, but I don't think that's really a problem?
For adding a .tilesource export, note that there is still some work to be done before Tiled can support export-only tileset formats (currently it supports only read-write formats). So before you work on this you may want to wait until I've had a chance to get around to that (I need to do this for adding Lua tileset export, and I'll do it in the wip/tilesetdocument branch).

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

yahuaru commented Jul 18, 2016

Ok. Thanks for mention lua export, it totally changed my plans for work. I have some free time on this week, so I expecting make radical changes really soon

-----Исходное сообщение-----
От: "Thorbjørn Lindeijer" notifications@github.com
Отправлено: ‎17.‎07.‎2016 23:06
Кому: "bjorn/tiled" tiled@noreply.github.com
Копия: "kekdck" exzo0mex@gmail.com; "Author" author@noreply.github.com
Тема: Re: [bjorn/tiled] Added export to Defold .tilemap files (#1316)

Alright, I understand it has some specific functionality for your project, but Defold seems to be pretty popular and it looked like Tiled can add a lot in terms of tile map editing. Hence I was eager to merge this plugin. However, indeed some changes to make it more generic would be good, so it's nice to hear you'd like to work on this.
Note that Tiled already has a generic Lua export. Maybe it would be better to rely on that for people who need more information from the Tiled map? Sure it will have some tile map stuff duplicated, but I don't think that's really a problem?
For adding a .tilesource export, note that there is still some work to be done before Tiled can support export-only tileset formats (currently it supports only read-write formats). So before you work on this you may want to wait until I've had a chance to get around to that (I need to do this for adding Lua tileset export, and I'll do it in the wip/tilesetdocument branch).

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@yahuaru

This comment has been minimized.

Show comment
Hide comment
@yahuaru

yahuaru Jul 22, 2016

Contributor
  • The flipped tiles in the orthogonal-outside.tmx example in the Tiled
    repository did not appear to get flipped in Defold. Is this feature somehow
    only supported in their.tilemap format, but not yet by their renderer? (I
    also can't find tile flipping in the Defold editor)

There is cell argument for horizontal/vertical flip. But it seems defold
don't care about them. Maybe tile flip not steel implemented.

  • What are the map_nodes and Objects tables for in
    the .tilemap.script file? Do I understand correctly, that these variables
    become global values in some Lua state

    I remade that part and used lua plugin for export information that not
    used in .tilemap into lua script.

  • Would there be some solution for the empty tileset_set property? As
    it is, each time after the export, you need to re-set the "Tile Source" in
    Defold. I imagine, that maybe an export for the tilesets
    to .tilesource could be added as well, since the properties are similar.
    And then Tiled may know which files to reference there when exporting the
    map.

I will look, what i can do with that, but i afraid there i don't have
solution for re-seting "Tile source".
Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-18 12:29 GMT+03:00 Nikita Razdobreev exzo0mex@gmail.com:

Ok. Thanks for mention lua export, it totally changed my plans for work. I
have some free time on this week, so I expecting make radical changes

really soon

От: Thorbjørn Lindeijer notifications@github.com
Отправлено: ‎17.‎07.‎2016 23:06
Кому: bjorn/tiled tiled@noreply.github.com
Копия: kekdck exzo0mex@gmail.com; Author author@noreply.github.com
Тема: Re: [bjorn/tiled] Added export to Defold .tilemap files (#1316)

Alright, I understand it has some specific functionality for your project,
but Defold seems to be pretty popular and it looked like Tiled can add a
lot in terms of tile map editing. Hence I was eager to merge this plugin.
However, indeed some changes to make it more generic would be good, so it's
nice to hear you'd like to work on this.

Note that Tiled already has a generic Lua export. Maybe it would be better
to rely on that for people who need more information from the Tiled map?
Sure it will have some tile map stuff duplicated, but I don't think that's
really a problem?

For adding a .tilesource export, note that there is still some work to be
done before Tiled can support export-only tileset formats (currently it
supports only read-write formats). So before you work on this you may want
to wait until I've had a chance to get around to that (I need to do this
for adding Lua tileset export, and I'll do it in the wip/tilesetdocument
branch).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB3QoS0rzhgsUxG1Ofo_P7L-iRke3L6Tks5qWos3gaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

Contributor

yahuaru commented Jul 22, 2016

  • The flipped tiles in the orthogonal-outside.tmx example in the Tiled
    repository did not appear to get flipped in Defold. Is this feature somehow
    only supported in their.tilemap format, but not yet by their renderer? (I
    also can't find tile flipping in the Defold editor)

There is cell argument for horizontal/vertical flip. But it seems defold
don't care about them. Maybe tile flip not steel implemented.

  • What are the map_nodes and Objects tables for in
    the .tilemap.script file? Do I understand correctly, that these variables
    become global values in some Lua state

    I remade that part and used lua plugin for export information that not
    used in .tilemap into lua script.

  • Would there be some solution for the empty tileset_set property? As
    it is, each time after the export, you need to re-set the "Tile Source" in
    Defold. I imagine, that maybe an export for the tilesets
    to .tilesource could be added as well, since the properties are similar.
    And then Tiled may know which files to reference there when exporting the
    map.

I will look, what i can do with that, but i afraid there i don't have
solution for re-seting "Tile source".
Sent with MailTrack
https://mailtrack.io/install?source=signature&lang=en&referral=exzo0mex@gmail.com&idSignature=22

2016-07-18 12:29 GMT+03:00 Nikita Razdobreev exzo0mex@gmail.com:

Ok. Thanks for mention lua export, it totally changed my plans for work. I
have some free time on this week, so I expecting make radical changes

really soon

От: Thorbjørn Lindeijer notifications@github.com
Отправлено: ‎17.‎07.‎2016 23:06
Кому: bjorn/tiled tiled@noreply.github.com
Копия: kekdck exzo0mex@gmail.com; Author author@noreply.github.com
Тема: Re: [bjorn/tiled] Added export to Defold .tilemap files (#1316)

Alright, I understand it has some specific functionality for your project,
but Defold seems to be pretty popular and it looked like Tiled can add a
lot in terms of tile map editing. Hence I was eager to merge this plugin.
However, indeed some changes to make it more generic would be good, so it's
nice to hear you'd like to work on this.

Note that Tiled already has a generic Lua export. Maybe it would be better
to rely on that for people who need more information from the Tiled map?
Sure it will have some tile map stuff duplicated, but I don't think that's
really a problem?

For adding a .tilesource export, note that there is still some work to be
done before Tiled can support export-only tileset formats (currently it
supports only read-write formats). So before you work on this you may want
to wait until I've had a chance to get around to that (I need to do this
for adding Lua tileset export, and I'll do it in the wip/tilesetdocument
branch).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1316 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB3QoS0rzhgsUxG1Ofo_P7L-iRke3L6Tks5qWos3gaJpZM4JOMFx
.

С уважением,
Раздобреев Никита

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment