New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rotate hexagonal tiles 60 degrees #1447

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nicolaichuk
Contributor

nicolaichuk commented Feb 16, 2017

@nicolaichuk nicolaichuk changed the title from support Rotate hexagonal tiles 60 degrees to Support rotate hexagonal tiles 60 degrees Feb 16, 2017

@bjorn

I've tried it out and I think it works well! I did have a few comments on the implementation, which I think could be easier to understand.

Thanks for working on this nice feature!

Show outdated Hide outdated src/libtiled/tilelayer.cpp
Show outdated Hide outdated src/libtiled/gidmapper.cpp
Show outdated Hide outdated src/libtiled/maprenderer.cpp
Show outdated Hide outdated src/libtiled/maprenderer.cpp
@nicolaichuk

This comment has been minimized.

Show comment
Hide comment
@nicolaichuk

nicolaichuk Mar 4, 2017

Contributor

@bjorn:
Please review and merge to main branch.

Contributor

nicolaichuk commented Mar 4, 2017

@bjorn:
Please review and merge to main branch.

@bjorn

See comments.

Show outdated Hide outdated src/libtiled/gidmapper.cpp
Show outdated Hide outdated src/libtiled/tilelayer.h
Show outdated Hide outdated src/libtiled/tilelayer.h
Show outdated Hide outdated src/tiled/tilestamp.cpp
Show outdated Hide outdated src/libtiled/maprenderer.cpp
Show outdated Hide outdated src/libtiled/maprenderer.h
Show outdated Hide outdated src/tiled/tilestamp.cpp
Show outdated Hide outdated src/libtiled/tilelayer.h
@nicolaichuk

This comment has been minimized.

Show comment
Hide comment
@nicolaichuk

nicolaichuk Mar 6, 2017

Contributor

@bjorn:
Please review and merge to main branch.

Contributor

nicolaichuk commented Mar 6, 2017

@bjorn:
Please review and merge to main branch.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 7, 2017

Owner

Merged as fae6ebd, thanks!

I've left out the Windows related changes to README.md. While I agree Qbs instructions should be added there, I didn't want to include them in the patch.

Owner

bjorn commented Mar 7, 2017

Merged as fae6ebd, thanks!

I've left out the Windows related changes to README.md. While I agree Qbs instructions should be added there, I didn't want to include them in the patch.

@bjorn bjorn closed this Mar 7, 2017

@nicolaichuk

This comment has been minimized.

Show comment
Hide comment
@nicolaichuk

nicolaichuk Mar 7, 2017

Contributor

@bjorn, thanks.

When will you plane create next release?

Contributor

nicolaichuk commented Mar 7, 2017

@bjorn, thanks.

When will you plane create next release?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 7, 2017

Owner

@nicolaichuk That would be Tiled 1.0, which I hope will be out in April or May. In the meantime though, this feature will be in the development snapshots later today, which are also easy to install on any platform.

Owner

bjorn commented Mar 7, 2017

@nicolaichuk That would be Tiled 1.0, which I hope will be out in April or May. In the meantime though, this feature will be in the development snapshots later today, which are also easy to install on any platform.

@nicolaichuk

This comment has been minimized.

Show comment
Hide comment
@nicolaichuk

nicolaichuk Mar 7, 2017

Contributor

@bjorn, Ok, thanks.

Contributor

nicolaichuk commented Mar 7, 2017

@bjorn, Ok, thanks.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 7, 2017

Owner

@nicolaichuk If you happen to find any time to improve hex rotation of multiple tiles that would be appreciated. If not, it'll be on my list of things to do before the release.

Owner

bjorn commented Mar 7, 2017

@nicolaichuk If you happen to find any time to improve hex rotation of multiple tiles that would be appreciated. If not, it'll be on my list of things to do before the release.

@nicolaichuk

This comment has been minimized.

Show comment
Hide comment
@nicolaichuk

nicolaichuk Mar 7, 2017

Contributor

@bjorn, I will now switch to other tasks for my project.
If I have free time, I'll see how I can help.

Contributor

nicolaichuk commented Mar 7, 2017

@bjorn, I will now switch to other tasks for my project.
If I have free time, I'll see how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment