Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
updated automapper.cpp #1524
I also added some comments (maybe some of them are too"trivial"?).
You're indeed rather verbose with the comments you've added, but I don't mind so much. I've mentioned two issues inline though.
@axboureau I've addressed this in change a22476f, which does essentially the same without allocating and freeing a lot of memory all the time (it certainly helps that tile layers are infinite now and only allocate chunks of memory on-demand).
I've tried to make this change, but it changed the behavior in a way that broke the "sewer_automap" example. It might still be that this behavior is desired in more cases, but I didn't want to break compatibility at this point. I'm hopeful that the new "StrictEmpty" mode would also solve your use-case, see the description of change eb1e850 for more information.
If that new option resolves your use-case, then I think we can close this PR and issue #1520. But I would also still be open to introduce another option for this if the option doesn't turn out to be so convenient (which I could definitely imagine).