Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow setting working directory #1580
This addresses #941. I've also split 'Command' to 'Executable' and 'Arguments'. I've shown the design in the issue and one of the reasons for this was
Well... I think if we have one central place to add new variables that should be just as easy. (if the quote handling is also done automatically). So I would think of one function which does all the replacement is then invoked for both, the command and the working directory.
Looks like a nice change overal! I've made some inline comments.
In addition, please make sure that existing commands remain functional as-is. It looks like currently their command will no longer be read out at all, but care should be taken not to break the command setup for existing users. Probably it would be enough to read in the "Command" setting into the new "Executable" setting.