New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean Translation #1604

Merged
merged 25 commits into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@miru2533
Contributor

miru2533 commented Jun 9, 2017

Our team made the complete Korean translation for Tiled!
It's our first PR, so please excuse if there is some mistake :)

--miru2533 and others added some commits May 19, 2017

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jun 9, 2017

Owner

That's great, I'll have a look at it soon!

At quick glance I noticed only one mistake, please delete the examples/sticker-knight/map/Thumbs.db file again, as this should not be added to the repository.

Owner

bjorn commented Jun 9, 2017

That's great, I'll have a look at it soon!

At quick glance I noticed only one mistake, please delete the examples/sticker-knight/map/Thumbs.db file again, as this should not be added to the repository.

miru2533
@miru2533

This comment has been minimized.

Show comment
Hide comment
@miru2533

miru2533 Jun 9, 2017

Contributor

Oh, I didn't recognize it.
I deleted that one.

Contributor

miru2533 commented Jun 9, 2017

Oh, I didn't recognize it.
I deleted that one.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jun 11, 2017

Owner

It is alright if I squash all the commits? Am I correct that the translation was effectively done by @miru2533 and @SshipSunBee?

Owner

bjorn commented Jun 11, 2017

It is alright if I squash all the commits? Am I correct that the translation was effectively done by @miru2533 and @SshipSunBee?

@miru2533

This comment has been minimized.

Show comment
Hide comment
@miru2533

miru2533 Jun 12, 2017

Contributor

Yes, it was done by two people and squashing is OK!

Contributor

miru2533 commented Jun 12, 2017

Yes, it was done by two people and squashing is OK!

@bjorn bjorn changed the base branch from master to 1.0 Jun 12, 2017

@bjorn bjorn merged commit e2fbb18 into bjorn:1.0 Jun 12, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jun 12, 2017

Owner

Thanks a lot! I've added you to the AUTHORS file in 8e6fb74.

Owner

bjorn commented Jun 12, 2017

Thanks a lot! I've added you to the AUTHORS file in 8e6fb74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment